Re: [PATCH v3 0/9] Qualcomm video decoder/encoder driver

From	Stanimir Varbanov <stanimir.varbanov@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 0/9] Qualcomm video decoder/encoder driver
Date	2016-11-14 16:00 +0100
Message-ID	<sDqTL-8jU-7@gated-at.bofh.it> (permalink)
References	<sAW3L-6lw-3@gated-at.bofh.it> <sCivg-3KY-21@gated-at.bofh.it> <sCiYi-4ee-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi,

On 11/11/2016 02:11 PM, Javier Martinez Canillas wrote:
> Hello Hans,
> 
> On Fri, Nov 11, 2016 at 8:49 AM, Hans Verkuil <hverkuil@xs4all.nl> wrote:
>> Hi Stanimir,
>>
>> Overall it looks good. As you saw, I do have some comments but nothing major.
>>
>> One question: you use qcom as the directory name. How about using qualcomm?
>>
>> It's really not that much longer and a bit more obvious.
>>
>> Up to you, though.
>>
> 
> It seems qcom is more consistent to the name used in most subsystems
> for Qualcomm:
> 
> $ find -name *qcom
> ./arch/arm/mach-qcom
> ./arch/arm64/boot/dts/qcom
> ./Documentation/devicetree/bindings/soc/qcom
> ./sound/soc/qcom
> ./drivers/pinctrl/qcom
> ./drivers/soc/qcom
> ./drivers/clk/qcom
> 
> $ find -name *qualcomm
> ./drivers/net/ethernet/qualcomm

Also qcom is the vendor prefix used in [1]

[1] Documentation/devicetree/bindings/vendor-prefixes.txt

-- 
regards,
Stan

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v3 0/9] Qualcomm video decoder/encoder driver Stanimir Varbanov <stanimir.varbanov@linaro.org> - 2016-11-14 16:00 +0100
  Re: [PATCH v3 0/9] Qualcomm video decoder/encoder driver Hans Verkuil <hverkuil@xs4all.nl> - 2016-11-14 16:10 +0100

csiph-web