Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1523119

Re: [net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver

From Lino Sanfilippo <LinoSanfilippo@gmx.de>
Newsgroups linux.kernel
Subject Re: [net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver
Date 2016-11-16 00:20 +0100
Message-ID <sDVbb-2Za-3@gated-at.bofh.it> (permalink)
References (6 earlier) <sDTVL-21f-5@gated-at.bofh.it> <sDUyt-2wx-5@gated-at.bofh.it> <sDUyt-2wx-3@gated-at.bofh.it> <sDURP-2Dt-5@gated-at.bofh.it> <sDV1v-2VT-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On 16.11.2016 00:03, Andrew Lunn wrote:
>> >>>>> +  			val = MII_BMCR << 16 | SLIC_PCR_AUTONEG |
>> >>>>> +		     	         SLIC_PCR_AUTONEG_RST;
>> >>>>> +			slic_write(sdev, SLIC_REG_WPHY, val);
> 
>> Thats essentially what I meant by setting a flag in the irq handler. The mdio
>> function would have to check somehow if the irq has been fired (be it by means
>> of a flag or a completion that is set by the irq handler and checked by the 
>> mdio function). So I agree that it should work (if reading via the AP command
>> is actually possible).
> 
> It seems odd you have a nice simple way to do writes, but reads are
> very complex. There might be a simple read method hiding somewhere.
> 
>      Andrew
> 

I agree, it IS odd :). 
But concerning reading the phy this is all I can see in the original source code:

http://lxr.free-electrons.com/source/drivers/staging/slicoss/slichw.h#L516

I strongly suspect that "RPHY" stand for "read phy". The only one who may
know for sure if there is another/better way is Christopher Harrer. He is also on CC
but I am not sure if he actually follows this discussion.

Lino

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Gigabit ethernet driver for Alacritechs SLIC devices Lino Sanfilippo <LinoSanfilippo@gmx.de> - 2016-11-13 05:50 +0100
  Re: [net-next 1/2] net: ethernet: slicoss: add slicoss gigabit  ethernet driver Andrew Lunn <andrew@lunn.ch> - 2016-11-13 21:00 +0100
    Re: [net-next 1/2] net: ethernet: slicoss: add slicoss gigabit  ethernet driver Lino Sanfilippo <LinoSanfilippo@gmx.de> - 2016-11-15 21:50 +0100
      Re: [net-next 1/2] net: ethernet: slicoss: add slicoss gigabit  ethernet driver Florian Fainelli <f.fainelli@gmail.com> - 2016-11-15 22:00 +0100
        Re: [net-next 1/2] net: ethernet: slicoss: add slicoss gigabit  ethernet driver Lino Sanfilippo <LinoSanfilippo@gmx.de> - 2016-11-15 22:30 +0100
          Re: [net-next 1/2] net: ethernet: slicoss: add slicoss gigabit  ethernet driver Andrew Lunn <andrew@lunn.ch> - 2016-11-15 23:00 +0100
            Re: [net-next 1/2] net: ethernet: slicoss: add slicoss gigabit  ethernet driver Florian Fainelli <f.fainelli@gmail.com> - 2016-11-15 23:40 +0100
              Re: [net-next 1/2] net: ethernet: slicoss: add slicoss gigabit  ethernet driver Lino Sanfilippo <LinoSanfilippo@gmx.de> - 2016-11-16 00:00 +0100
                Re: [net-next 1/2] net: ethernet: slicoss: add slicoss gigabit  ethernet driver Andrew Lunn <andrew@lunn.ch> - 2016-11-16 00:10 +0100
                Re: [net-next 1/2] net: ethernet: slicoss: add slicoss gigabit  ethernet driver Lino Sanfilippo <LinoSanfilippo@gmx.de> - 2016-11-16 00:20 +0100
            Re: [net-next 1/2] net: ethernet: slicoss: add slicoss gigabit  ethernet driver Lino Sanfilippo <LinoSanfilippo@gmx.de> - 2016-11-15 23:40 +0100
              Aw: Re: [net-next 1/2] net: ethernet: slicoss: add slicoss gigabit  ethernet driver "Lino Sanfilippo" <LinoSanfilippo@gmx.de> - 2016-11-24 13:40 +0100

csiph-web