Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1523061
| From | Florian Fainelli <f.fainelli@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver |
| Date | 2016-11-15 22:00 +0100 |
| Message-ID | <sDSZI-1sK-15@gated-at.bofh.it> (permalink) |
| References | <sCUTT-3LN-3@gated-at.bofh.it> <sCUTU-3LN-19@gated-at.bofh.it> <sD96x-4KN-11@gated-at.bofh.it> <sDSQ1-1pd-1@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 11/15/2016 12:46 PM, Lino Sanfilippo wrote: >> Could this be pulled out into a standard PHY driver? All the SLIC >> SLIC_PCR_ defines seems to be the same as those in mii.h. This could >> be a standard PHY hidden behind a single register. >> >> Andrew > > You are right, the driver should really use the defines in mii.h. I will fix this in > a v2. > > Concerning the use of the PHY API: What would be the advantage of using it? Note that the > phy is always internal and not interchangeable. Is not the interchangeability of PHYs > the main reason for using this API? Not reinventing the wheel primarily, while PHYLIB also solves the plug & play aspect of external PHYs, it also solves the basic link management, and consistent and reasonably well defined interface to user-space and drivers (statistics reporting, link, auto-negotiation, EEE etc.). -- Florian
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Gigabit ethernet driver for Alacritechs SLIC devices Lino Sanfilippo <LinoSanfilippo@gmx.de> - 2016-11-13 05:50 +0100
Re: [net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver Andrew Lunn <andrew@lunn.ch> - 2016-11-13 21:00 +0100
Re: [net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver Lino Sanfilippo <LinoSanfilippo@gmx.de> - 2016-11-15 21:50 +0100
Re: [net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver Florian Fainelli <f.fainelli@gmail.com> - 2016-11-15 22:00 +0100
Re: [net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver Lino Sanfilippo <LinoSanfilippo@gmx.de> - 2016-11-15 22:30 +0100
Re: [net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver Andrew Lunn <andrew@lunn.ch> - 2016-11-15 23:00 +0100
Re: [net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver Florian Fainelli <f.fainelli@gmail.com> - 2016-11-15 23:40 +0100
Re: [net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver Lino Sanfilippo <LinoSanfilippo@gmx.de> - 2016-11-16 00:00 +0100
Re: [net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver Andrew Lunn <andrew@lunn.ch> - 2016-11-16 00:10 +0100
Re: [net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver Lino Sanfilippo <LinoSanfilippo@gmx.de> - 2016-11-16 00:20 +0100
Re: [net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver Lino Sanfilippo <LinoSanfilippo@gmx.de> - 2016-11-15 23:40 +0100
Aw: Re: [net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver "Lino Sanfilippo" <LinoSanfilippo@gmx.de> - 2016-11-24 13:40 +0100
csiph-web