Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1520180

Re: [PATCH 2/3] cpufreq: schedutil: move slow path from workqueue to SCHED_FIFO task

From Viresh Kumar <viresh.kumar@linaro.org>
Newsgroups linux.kernel
Subject Re: [PATCH 2/3] cpufreq: schedutil: move slow path from workqueue to SCHED_FIFO task
Date 2016-11-12 06:30 +0100
Message-ID <sCz33-6bf-9@gated-at.bofh.it> (permalink)
References <sChfQ-35W-17@gated-at.bofh.it> <sChfQ-35W-19@gated-at.bofh.it> <sCskV-1Uz-11@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 12 November 2016 at 03:46, Rafael J. Wysocki <rafael@kernel.org> wrote:

>> +static void sugov_work(struct kthread_work *work)
>>  {
>> -       struct sugov_policy *sg_policy = container_of(work, struct sugov_policy, work);
>> +       struct sugov_policy *sg_policy =
>> +               container_of(work, struct sugov_policy, work);
>
> Why this change?

Mistake ..

>>  static struct sugov_policy *sugov_policy_alloc(struct cpufreq_policy *policy)
>>  {
>>         struct sugov_policy *sg_policy;
>> +       struct task_struct *thread;
>> +       struct sched_param param = { .sched_priority = 50 };
>
> I'd define a symbol for the 50.  It's just one extra line of code ...

Sure.

As I asked in the cover letter, will you be fine if I send the same patch
for ondemand/conservative governors ?

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 2/3] cpufreq: schedutil: move slow path from workqueue to SCHED_FIFO task Viresh Kumar <viresh.kumar@linaro.org> - 2016-11-11 11:30 +0100
  Re: [PATCH 2/3] cpufreq: schedutil: move slow path from workqueue to  SCHED_FIFO task Tommaso Cucinotta <tommaso.cucinotta@sssup.it> - 2016-11-11 15:40 +0100
    Re: [PATCH 2/3] cpufreq: schedutil: move slow path from workqueue to  SCHED_FIFO task Peter Zijlstra <peterz@infradead.org> - 2016-11-11 15:40 +0100
      Re: [PATCH 2/3] cpufreq: schedutil: move slow path from workqueue to  SCHED_FIFO task Viresh Kumar <viresh.kumar@linaro.org> - 2016-11-12 06:30 +0100
        Re: [PATCH 2/3] cpufreq: schedutil: move slow path from workqueue to  SCHED_FIFO task Peter Zijlstra <peterz@infradead.org> - 2016-11-14 10:30 +0100
          Re: [PATCH 2/3] cpufreq: schedutil: move slow path from workqueue to  SCHED_FIFO task Viresh Kumar <viresh.kumar@linaro.org> - 2016-11-14 11:30 +0100
    Re: [PATCH 2/3] cpufreq: schedutil: move slow path from workqueue to  SCHED_FIFO task Viresh Kumar <viresh.kumar@linaro.org> - 2016-11-12 06:30 +0100
  Re: [PATCH 2/3] cpufreq: schedutil: move slow path from workqueue to  SCHED_FIFO task "Rafael J. Wysocki" <rafael@kernel.org> - 2016-11-11 23:20 +0100
    Re: [PATCH 2/3] cpufreq: schedutil: move slow path from workqueue  to SCHED_FIFO task Saravana Kannan <skannan@codeaurora.org> - 2016-11-12 02:40 +0100
      Re: [PATCH 2/3] cpufreq: schedutil: move slow path from workqueue to  SCHED_FIFO task Viresh Kumar <viresh.kumar@linaro.org> - 2016-11-12 06:30 +0100
        Re: [PATCH 2/3] cpufreq: schedutil: move slow path from workqueue to  SCHED_FIFO task Viresh Kumar <viresh.kumar@linaro.org> - 2016-11-14 06:40 +0100
      Re: [PATCH 2/3] cpufreq: schedutil: move slow path from workqueue to  SCHED_FIFO task "Rafael J. Wysocki" <rafael@kernel.org> - 2016-11-13 15:40 +0100
        Re: [PATCH 2/3] cpufreq: schedutil: move slow path from workqueue to  SCHED_FIFO task Steve Muckle <smuckle.linux@gmail.com> - 2016-11-13 20:50 +0100
          Re: [PATCH 2/3] cpufreq: schedutil: move slow path from workqueue to  SCHED_FIFO task "Rafael J. Wysocki" <rafael@kernel.org> - 2016-11-13 23:50 +0100
            Re: [PATCH 2/3] cpufreq: schedutil: move slow path from workqueue to  SCHED_FIFO task Viresh Kumar <viresh.kumar@linaro.org> - 2016-11-14 07:40 +0100
    Re: [PATCH 2/3] cpufreq: schedutil: move slow path from workqueue to  SCHED_FIFO task Viresh Kumar <viresh.kumar@linaro.org> - 2016-11-12 06:30 +0100
    Re: [PATCH 2/3] cpufreq: schedutil: move slow path from workqueue to  SCHED_FIFO task Steve Muckle <smuckle.linux@gmail.com> - 2016-11-13 21:00 +0100

csiph-web