Groups > linux.kernel > #1519326

Re: [patch] staging: lustre: lov: crash in error handling

From	James Simmons <jsimmons@infradead.org>
Newsgroups	linux.kernel
Subject	Re: [patch] staging: lustre: lov: crash in error handling
Date	2016-11-10 20:50 +0100
Message-ID	<sC3we-2e1-23@gated-at.bofh.it> (permalink)
References	<sC3we-2e1-25@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

> We accidentally made this unsigned so now the error handling will loop
> until it crashes.
> 
> Fixes: 55051039fdad ('staging: lustre: lov: remove LSM from struct lustre_md')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Yep. I just sent a patch to fix that. 

> diff --git a/drivers/staging/lustre/lustre/lov/lov_ea.c b/drivers/staging/lustre/lustre/lov/lov_ea.c
> index 53db170..2e2abed 100644
> --- a/drivers/staging/lustre/lustre/lov/lov_ea.c
> +++ b/drivers/staging/lustre/lustre/lov/lov_ea.c
> @@ -81,7 +81,7 @@ struct lov_stripe_md *lsm_alloc_plain(u16 stripe_count)
>  	size_t oinfo_ptrs_size, lsm_size;
>  	struct lov_stripe_md *lsm;
>  	struct lov_oinfo     *loi;
> -	unsigned int i;
> +	int i;
>  
>  	LASSERT(stripe_count <= LOV_MAX_STRIPE_COUNT);
>  
>

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [patch] staging: lustre: lov: crash in error handling James Simmons <jsimmons@infradead.org> - 2016-11-10 20:50 +0100

csiph-web