Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1519125

Re: [PATCH 01/25] fs/buffer: Convert to hotplug state machine

Show all headers | View raw

On Thu, 10 Nov 2016, Al Viro wrote:

> On Thu, Nov 03, 2016 at 03:49:57PM +0100, Sebastian Andrzej Siewior wrote:
> > Install the callbacks via the state machine.
> 
> > diff --git a/include/linux/cpuhotplug.h b/include/linux/cpuhotplug.h
> > index afe641c02dca..69b74fa0da60 100644
> > --- a/include/linux/cpuhotplug.h
> > +++ b/include/linux/cpuhotplug.h
> > @@ -30,6 +30,7 @@ enum cpuhp_state {
> >  	CPUHP_ACPI_CPUDRV_DEAD,
> >  	CPUHP_S390_PFAULT_DEAD,
> >  	CPUHP_BLK_MQ_DEAD,
> > +	CPUHP_FS_BUFF_DEAD,
> >  	CPUHP_WORKQUEUE_PREP,
> >  	CPUHP_POWER_NUMA_PREPARE,
> >  	CPUHP_HRTIMERS_PREPARE,
> 
> *ouch*
> 
> So we are getting a large list of things from unrelated subsystems, maintained
> in a single place, all next to each other.  All examples of that sort of
> thing I can recall had ended up biting our arses...

I rather have my arse bitten by a few merge conflicts than constantly
chasing why odering by chance, link order or magic constants in random
files make things explode or not work.

Thanks,

	tglx

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 01/25] fs/buffer: Convert to hotplug state machine Sebastian Andrzej Siewior <bigeasy@linutronix.de> - 2016-11-03 16:00 +0100
  [tip:smp/hotplug] fs/buffer: Convert to hotplug state machine tip-bot for Sebastian Andrzej Siewior <tipbot@zytor.com> - 2016-11-10 00:00 +0100
  Re: [PATCH 01/25] fs/buffer: Convert to hotplug state machine Al Viro <viro@ZenIV.linux.org.uk> - 2016-11-10 17:30 +0100
    Re: [PATCH 01/25] fs/buffer: Convert to hotplug state machine Thomas Gleixner <tglx@linutronix.de> - 2016-11-10 17:40 +0100

csiph-web