Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1517919

Re: [PATCH v1 03/11] drivers: soc: hisi: Add support for Hisilicon Djtag driver

Show all headers | View raw

On Tuesday 08 November 2016 08:40 PM, Arnd Bergmann wrote:
> On Tuesday, November 8, 2016 1:49:43 PM CET John Garry wrote:
>> Hi Arnd,
>>
>> Thanks for the reference.
>>
>> I think the i2c interface doesn't fully satisfy our requirements as we
>> need more than just a slave bus address when accessing the slave device
>> (which I think is what i2c uses). We also need to pass "offset" and
>> "mod_mask" arguments to the djtag adapter to access specific registers
>> in the slave device.
> Ok. Are those values constant per device, or maybe a range? We may want to
> include those in the reg property as well then.
>
> 	Arnd
>
Hi Arnd,

The "mod_mask" is to select the sub-module within a module. This 
parameter is
used for djtag write operation.
In the case of L3 cache, this will select the L3 cache bank. 0xFFFF 
select all banks.
This value will  change based on the L3 cache bank to be written to. I 
think this value
can be in the driver itself.

For djtag read operation, the "mod_mask" is ignored. instead the input 
parameter
"chain_id" is used. this will identify the sub-module or bank.

For djtag-v1, the "chain_id" is different for each L3 cache bank, But in 
the case of
djtag-v2 the "chain_id" is fixed and the value is 0 as In djtag-v2 there 
is separate
"module-id" for each sub-module.

The "offset" is the register offset and this value is a range for a module.

Thanks,
Anurup

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v1 00/11] perf: arm64: Support for Hisilicon SoC Hardware event counters Anurup M <anurupvasu@gmail.com> - 2016-11-02 16:50 +0100
  [PATCH v1 09/11] perf: hisi: Miscellanous node(MN) event counting in perf Anurup M <anurupvasu@gmail.com> - 2016-11-02 16:50 +0100
  [PATCH v1 02/11] dt-bindings: hisi: Add Hisilicon HiP05/06/07 Sysctrl and Djtag dts bindings Anurup M <anurupvasu@gmail.com> - 2016-11-02 16:50 +0100
  [PATCH v1 06/11] perf: hisi: Update Kconfig for Hisilicon PMU support Anurup M <anurupvasu@gmail.com> - 2016-11-02 16:50 +0100
  [PATCH v1 10/11] perf: hisi: Support for Hisilicon DDRC PMU. Anurup M <anurupvasu@gmail.com> - 2016-11-02 16:50 +0100
  [PATCH v1 08/11] perf: hisi: Add sysfs attributes for L3 cache(L3C) PMU Anurup M <anurupvasu@gmail.com> - 2016-11-02 16:50 +0100
  [PATCH v1 04/11] Documentation: perf: hisi: Documentation for HIP05/06/07 PMU event counting. Anurup M <anurupvasu@gmail.com> - 2016-11-02 16:50 +0100
  [PATCH v1 01/11] arm64: MAINTAINERS: hisi: Add hisilicon SoC PMU support Anurup M <anurupvasu@gmail.com> - 2016-11-02 16:50 +0100
  [PATCH v1 03/11] drivers: soc: hisi: Add support for Hisilicon Djtag driver Anurup M <anurupvasu@gmail.com> - 2016-11-02 16:50 +0100
    Re: [PATCH v1 03/11] drivers: soc: hisi: Add support for Hisilicon Djtag driver Arnd Bergmann <arnd@arndb.de> - 2016-11-07 14:30 +0100
      Re: [PATCH v1 03/11] drivers: soc: hisi: Add support for Hisilicon  Djtag driver John Garry <john.garry@huawei.com> - 2016-11-07 15:20 +0100
        Re: [PATCH v1 03/11] drivers: soc: hisi: Add support for Hisilicon Djtag driver Arnd Bergmann <arnd@arndb.de> - 2016-11-07 21:10 +0100
          Re: [PATCH v1 03/11] drivers: soc: hisi: Add support for Hisilicon  Djtag driver John Garry <john.garry@huawei.com> - 2016-11-08 12:40 +0100
            Re: [PATCH v1 03/11] drivers: soc: hisi: Add support for Hisilicon Djtag driver Arnd Bergmann <arnd@arndb.de> - 2016-11-08 12:50 +0100
              Re: [PATCH v1 03/11] drivers: soc: hisi: Add support for Hisilicon  Djtag driver John Garry <john.garry@huawei.com> - 2016-11-08 15:00 +0100
                Re: [PATCH v1 03/11] drivers: soc: hisi: Add support for Hisilicon Djtag driver Arnd Bergmann <arnd@arndb.de> - 2016-11-08 16:20 +0100
                Re: [PATCH v1 03/11] drivers: soc: hisi: Add support for Hisilicon  Djtag driver John Garry <john.garry@huawei.com> - 2016-11-08 16:20 +0100
                Re: [PATCH v1 03/11] drivers: soc: hisi: Add support for Hisilicon  Djtag driver Anurup M <anurupvasu@gmail.com> - 2016-11-09 12:00 +0100
              Re: [PATCH v1 03/11] drivers: soc: hisi: Add support for Hisilicon  Djtag driver Anurup M <anurupvasu@gmail.com> - 2016-11-08 17:00 +0100
                Re: [PATCH v1 03/11] drivers: soc: hisi: Add support for Hisilicon  Djtag driver John Garry <john.garry@huawei.com> - 2016-11-09 10:10 +0100
                Re: [PATCH v1 03/11] drivers: soc: hisi: Add support for Hisilicon  Djtag driver Anurup M <anurupvasu@gmail.com> - 2016-11-11 11:40 +0100
      Re: [PATCH v1 03/11] drivers: soc: hisi: Add support for Hisilicon  Djtag driver Tan Xiaojun <tanxiaojun@huawei.com> - 2016-11-08 08:10 +0100
        Re: [PATCH v1 03/11] drivers: soc: hisi: Add support for Hisilicon  Djtag driver Anurup M <anurupvasu@gmail.com> - 2016-11-08 08:40 +0100
          Re: [PATCH v1 03/11] drivers: soc: hisi: Add support for Hisilicon Djtag driver Arnd Bergmann <arnd@arndb.de> - 2016-11-08 12:50 +0100
            Re: [PATCH v1 03/11] drivers: soc: hisi: Add support for Hisilicon  Djtag driver Anurup M <anurupvasu@gmail.com> - 2016-11-08 14:50 +0100
              Re: [PATCH v1 03/11] drivers: soc: hisi: Add support for Hisilicon Djtag driver Arnd Bergmann <arnd@arndb.de> - 2016-11-08 16:20 +0100
                Re: [PATCH v1 03/11] drivers: soc: hisi: Add support for Hisilicon  Djtag driver Anurup M <anurupvasu@gmail.com> - 2016-11-09 05:30 +0100
                Re: [PATCH v1 03/11] drivers: soc: hisi: Add support for Hisilicon Djtag driver Arnd Bergmann <arnd@arndb.de> - 2016-11-09 22:50 +0100
                Re: [PATCH v1 03/11] drivers: soc: hisi: Add support for Hisilicon  Djtag driver Anurup M <anurupvasu@gmail.com> - 2016-11-11 11:30 +0100
  [PATCH v1 07/11] perf: hisi: Add support for Hisilicon SoC event counters Anurup M <anurupvasu@gmail.com> - 2016-11-02 16:50 +0100
  [PATCH v1 05/11] dt-bindings: perf: hisi: Add Devicetree bindings for Hisilicon SoC PMU Anurup M <anurupvasu@gmail.com> - 2016-11-02 16:50 +0100

csiph-web