Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1517108
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v1 03/11] drivers: soc: hisi: Add support for Hisilicon Djtag driver |
| Date | 2016-11-08 12:50 +0100 |
| Message-ID | <sBd4B-lV-5@gated-at.bofh.it> (permalink) |
| References | <sz5Xz-87s-3@gated-at.bofh.it> <sAYoV-7Xw-15@gated-at.bofh.it> <sBcUW-iC-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Tuesday, November 8, 2016 11:23:35 AM CET John Garry wrote:
> On 07/11/2016 20:08, Arnd Bergmann wrote:
> > On Monday, November 7, 2016 2:15:10 PM CET John Garry wrote:
> >>
> >> Hi Arnd,
> >>
> >> The new bus type tries to model the djtag in a similar way to I2C/USB
> >> driver arch, where we have a host bus adapter and child devices attached
> >> to the bus. The child devices are bus driver devices and have bus
> >> addresses. We think of the djtag as a separate bus, so we are modelling
> >> it as such.
> >>
> >> The bus driver offers a simple host interface for clients to read/write
> >> to the djtag bus: bus accesses are hidden from the client, the host
> >> drives the bus.
> >
> > Ok, in that case we should probably start out by having a bus specific
> > DT binding, and separating the description from that of the bus master
> > device.
>
> OK
>
> >
> > I'd suggest requiring #address-cells=<1> and #size-cells=<0> in the master
> > node, and listing the children by reg property. If the address is not
> > easily expressed as a single integer, use a larger #address-cells value.
>
> We already have something equivalent to reg in "module-id" (see patch
> 02/11), which is the slave device bus address; here's a sample:
> + /* For L3 cache PMU */
> + pmul3c0 {
> + compatible = "hisilicon,hisi-pmu-l3c-v1";
> + scl-id = <0x02>;
> + num-events = <0x16>;
> + num-counters = <0x08>;
> + module-id = <0x04>;
> + num-banks = <0x04>;
> + cfgen-map = <0x02 0x04 0x01 0x08>;
> + counter-reg = <0x170>;
> + evctrl-reg = <0x04>;
> + event-en = <0x1000000>;
> + evtype-reg = <0x140>;
> + };
>
> FYI, "module-id" is our own internal hw nomenclature.
Yes, that was my interpretation as well. Please use the standard
"reg" property for this then.
> > Another option that we have previously used was to actually pretend that
> > a vendor specific bus is an i2c bus and use the i2c probing infrastructure,
> > but that only makes sense if the software side closely resembles i2c
> > (this was the case for Allwinner I think, but I have not looked at
> > your driver in enough detail to know if it is true here as well).
> >
>
> OK, let me check this. By chance do you remember the specific AllWinner
> driver/hw?
drivers/i2c/busses/i2c-sun6i-p2wi.c
Arnd
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v1 00/11] perf: arm64: Support for Hisilicon SoC Hardware event counters Anurup M <anurupvasu@gmail.com> - 2016-11-02 16:50 +0100
[PATCH v1 09/11] perf: hisi: Miscellanous node(MN) event counting in perf Anurup M <anurupvasu@gmail.com> - 2016-11-02 16:50 +0100
[PATCH v1 02/11] dt-bindings: hisi: Add Hisilicon HiP05/06/07 Sysctrl and Djtag dts bindings Anurup M <anurupvasu@gmail.com> - 2016-11-02 16:50 +0100
[PATCH v1 06/11] perf: hisi: Update Kconfig for Hisilicon PMU support Anurup M <anurupvasu@gmail.com> - 2016-11-02 16:50 +0100
[PATCH v1 10/11] perf: hisi: Support for Hisilicon DDRC PMU. Anurup M <anurupvasu@gmail.com> - 2016-11-02 16:50 +0100
[PATCH v1 08/11] perf: hisi: Add sysfs attributes for L3 cache(L3C) PMU Anurup M <anurupvasu@gmail.com> - 2016-11-02 16:50 +0100
[PATCH v1 04/11] Documentation: perf: hisi: Documentation for HIP05/06/07 PMU event counting. Anurup M <anurupvasu@gmail.com> - 2016-11-02 16:50 +0100
[PATCH v1 01/11] arm64: MAINTAINERS: hisi: Add hisilicon SoC PMU support Anurup M <anurupvasu@gmail.com> - 2016-11-02 16:50 +0100
[PATCH v1 03/11] drivers: soc: hisi: Add support for Hisilicon Djtag driver Anurup M <anurupvasu@gmail.com> - 2016-11-02 16:50 +0100
Re: [PATCH v1 03/11] drivers: soc: hisi: Add support for Hisilicon Djtag driver Arnd Bergmann <arnd@arndb.de> - 2016-11-07 14:30 +0100
Re: [PATCH v1 03/11] drivers: soc: hisi: Add support for Hisilicon Djtag driver John Garry <john.garry@huawei.com> - 2016-11-07 15:20 +0100
Re: [PATCH v1 03/11] drivers: soc: hisi: Add support for Hisilicon Djtag driver Arnd Bergmann <arnd@arndb.de> - 2016-11-07 21:10 +0100
Re: [PATCH v1 03/11] drivers: soc: hisi: Add support for Hisilicon Djtag driver John Garry <john.garry@huawei.com> - 2016-11-08 12:40 +0100
Re: [PATCH v1 03/11] drivers: soc: hisi: Add support for Hisilicon Djtag driver Arnd Bergmann <arnd@arndb.de> - 2016-11-08 12:50 +0100
Re: [PATCH v1 03/11] drivers: soc: hisi: Add support for Hisilicon Djtag driver John Garry <john.garry@huawei.com> - 2016-11-08 15:00 +0100
Re: [PATCH v1 03/11] drivers: soc: hisi: Add support for Hisilicon Djtag driver Arnd Bergmann <arnd@arndb.de> - 2016-11-08 16:20 +0100
Re: [PATCH v1 03/11] drivers: soc: hisi: Add support for Hisilicon Djtag driver John Garry <john.garry@huawei.com> - 2016-11-08 16:20 +0100
Re: [PATCH v1 03/11] drivers: soc: hisi: Add support for Hisilicon Djtag driver Anurup M <anurupvasu@gmail.com> - 2016-11-09 12:00 +0100
Re: [PATCH v1 03/11] drivers: soc: hisi: Add support for Hisilicon Djtag driver Anurup M <anurupvasu@gmail.com> - 2016-11-08 17:00 +0100
Re: [PATCH v1 03/11] drivers: soc: hisi: Add support for Hisilicon Djtag driver John Garry <john.garry@huawei.com> - 2016-11-09 10:10 +0100
Re: [PATCH v1 03/11] drivers: soc: hisi: Add support for Hisilicon Djtag driver Anurup M <anurupvasu@gmail.com> - 2016-11-11 11:40 +0100
Re: [PATCH v1 03/11] drivers: soc: hisi: Add support for Hisilicon Djtag driver Tan Xiaojun <tanxiaojun@huawei.com> - 2016-11-08 08:10 +0100
Re: [PATCH v1 03/11] drivers: soc: hisi: Add support for Hisilicon Djtag driver Anurup M <anurupvasu@gmail.com> - 2016-11-08 08:40 +0100
Re: [PATCH v1 03/11] drivers: soc: hisi: Add support for Hisilicon Djtag driver Arnd Bergmann <arnd@arndb.de> - 2016-11-08 12:50 +0100
Re: [PATCH v1 03/11] drivers: soc: hisi: Add support for Hisilicon Djtag driver Anurup M <anurupvasu@gmail.com> - 2016-11-08 14:50 +0100
Re: [PATCH v1 03/11] drivers: soc: hisi: Add support for Hisilicon Djtag driver Arnd Bergmann <arnd@arndb.de> - 2016-11-08 16:20 +0100
Re: [PATCH v1 03/11] drivers: soc: hisi: Add support for Hisilicon Djtag driver Anurup M <anurupvasu@gmail.com> - 2016-11-09 05:30 +0100
Re: [PATCH v1 03/11] drivers: soc: hisi: Add support for Hisilicon Djtag driver Arnd Bergmann <arnd@arndb.de> - 2016-11-09 22:50 +0100
Re: [PATCH v1 03/11] drivers: soc: hisi: Add support for Hisilicon Djtag driver Anurup M <anurupvasu@gmail.com> - 2016-11-11 11:30 +0100
[PATCH v1 07/11] perf: hisi: Add support for Hisilicon SoC event counters Anurup M <anurupvasu@gmail.com> - 2016-11-02 16:50 +0100
[PATCH v1 05/11] dt-bindings: perf: hisi: Add Devicetree bindings for Hisilicon SoC PMU Anurup M <anurupvasu@gmail.com> - 2016-11-02 16:50 +0100
csiph-web