Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1517793

Re: [PATCH v4 1/3] leds: Introduce userspace leds driver

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi!

> >+struct uleds_device {
> >+	struct uleds_user_dev	user_dev;
> >+	struct led_classdev	led_cdev;
> >+	struct mutex		mutex;
> >+	enum uleds_state	state;
> >+	wait_queue_head_t	waitq;
> >+	unsigned char		brightness;
> 
> I've just noticed that this is wrong, since LED subsystem
> brightness type is enum led_brightness, i.e. int.
> LED_FULL (255) value is a legacy enum value that can be overridden
> by max_brightness property.
> 
> Please submit a fix so that I could merge it with the original
> patch before sending it upstream.

Actually... perhaps you want to wait with merging the userspace driver
till the locking is solved in the LED subsystem? Maybe I'm wrong, but
I have feeling that userspace driver will have unusual requirements
w.r.t. locking, and that it would be good to have that solved,
first...

Best regards,
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v4 1/3] leds: Introduce userspace leds driver Jacek Anaszewski <j.anaszewski@samsung.com> - 2016-11-08 12:50 +0100
  Re: [PATCH v4 1/3] leds: Introduce userspace leds driver David Lechner <david@lechnology.com> - 2016-11-08 20:10 +0100
    Re: [PATCH v4 1/3] leds: Introduce userspace leds driver Jacek Anaszewski <jacek.anaszewski@gmail.com> - 2016-11-08 21:40 +0100
  Re: [PATCH v4 1/3] leds: Introduce userspace leds driver Pavel Machek <pavel@ucw.cz> - 2016-11-09 08:10 +0100
    Re: [PATCH v4 1/3] leds: Introduce userspace leds driver Jacek Anaszewski <j.anaszewski@samsung.com> - 2016-11-09 09:50 +0100

csiph-web