Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1517502
| From | David Lechner <david@lechnology.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v4 1/3] leds: Introduce userspace leds driver |
| Date | 2016-11-08 20:10 +0100 |
| Message-ID | <sBjWr-53v-83@gated-at.bofh.it> (permalink) |
| References | <si6Q1-uW-5@gated-at.bofh.it> <sBd4C-lV-13@gated-at.bofh.it> <si6Q1-uW-3@gated-at.bofh.it> <sBd4C-lV-11@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 11/8/16 5:26 AM, Jacek Anaszewski wrote:
> Hi David,
>
>> +struct uleds_device {
>> + struct uleds_user_dev user_dev;
>> + struct led_classdev led_cdev;
>> + struct mutex mutex;
>> + enum uleds_state state;
>> + wait_queue_head_t waitq;
>> + unsigned char brightness;
>
> I've just noticed that this is wrong, since LED subsystem
> brightness type is enum led_brightness, i.e. int.
> LED_FULL (255) value is a legacy enum value that can be overridden
> by max_brightness property.
>
> Please submit a fix so that I could merge it with the original
> patch before sending it upstream.
>
> Thanks,
> Jacek Anaszewski
>
The brightness should be a 32-bit integer then?
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH v4 1/3] leds: Introduce userspace leds driver Jacek Anaszewski <j.anaszewski@samsung.com> - 2016-11-08 12:50 +0100
Re: [PATCH v4 1/3] leds: Introduce userspace leds driver David Lechner <david@lechnology.com> - 2016-11-08 20:10 +0100
Re: [PATCH v4 1/3] leds: Introduce userspace leds driver Jacek Anaszewski <jacek.anaszewski@gmail.com> - 2016-11-08 21:40 +0100
Re: [PATCH v4 1/3] leds: Introduce userspace leds driver Pavel Machek <pavel@ucw.cz> - 2016-11-09 08:10 +0100
Re: [PATCH v4 1/3] leds: Introduce userspace leds driver Jacek Anaszewski <j.anaszewski@samsung.com> - 2016-11-09 09:50 +0100
csiph-web