Re: [PATCH 2/2] clk: pxa: fix pxa2xx_determine_rate return

From	Robert Jarzmik <robert.jarzmik@free.fr>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] clk: pxa: fix pxa2xx_determine_rate return
Date	2016-11-09 08:40 +0100
Message-ID	<sBvEd-4gF-1@gated-at.bofh.it> (permalink)
References	<sBg2u-2e5-27@gated-at.bofh.it> <sBg2v-2e5-43@gated-at.bofh.it> <sBj0l-4ko-17@gated-at.bofh.it> <sBn3X-780-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Arnd Bergmann <arnd@arndb.de> writes:

> On Tuesday, November 8, 2016 7:01:57 PM CET Robert Jarzmik wrote:
>> Arnd Bergmann <arnd@arndb.de> writes:
>> If a non-exact match is found, either by closest_below or closest_above, rate is
>> set (rate = freqs[closest_xxx].cpll). And a couple of lines later after the
>> if/else, req->rate = rate is set as well, so I don't think this part of the
>> commit message is accurate.
>
> It is only set if rate is zero, and that normally is not the case here:
>
>        if (!rate)
>                req->rate = rate;
Ah ok, that's where the bug was lurking, if should have been "if (rate)".

But anyway, after comparing the end result of your code and mine, I find yours
more maintainable, especially the replacement of 'ret = 0'.

So let's proceed, thanks for finding this one out.
Acked-by: Robert Jarzmik <robert.jarzmik@free.fr>

--
Robert

Thread

[PATCH 1/2] clk: pxa mark dummy helper as 'inline' Arnd Bergmann <arnd@arndb.de> - 2016-11-08 16:00 +0100
  [PATCH 2/2] clk: pxa: fix pxa2xx_determine_rate return Arnd Bergmann <arnd@arndb.de> - 2016-11-08 16:00 +0100
    Re: [PATCH 2/2] clk: pxa: fix pxa2xx_determine_rate return Robert Jarzmik <robert.jarzmik@free.fr> - 2016-11-08 19:10 +0100
      Re: [PATCH 2/2] clk: pxa: fix pxa2xx_determine_rate return Arnd Bergmann <arnd@arndb.de> - 2016-11-08 23:30 +0100
        Re: [PATCH 2/2] clk: pxa: fix pxa2xx_determine_rate return Robert Jarzmik <robert.jarzmik@free.fr> - 2016-11-09 08:40 +0100
    Re: [PATCH 2/2] clk: pxa: fix pxa2xx_determine_rate return Stephen Boyd <sboyd@codeaurora.org> - 2016-11-09 21:10 +0100
  Re: [PATCH 1/2] clk: pxa mark dummy helper as 'inline' Robert Jarzmik <robert.jarzmik@free.fr> - 2016-11-08 19:00 +0100
  Re: [PATCH 1/2] clk: pxa mark dummy helper as 'inline' Stephen Boyd <sboyd@codeaurora.org> - 2016-11-08 23:50 +0100
    Re: [PATCH 1/2] clk: pxa mark dummy helper as 'inline' Arnd Bergmann <arnd@arndb.de> - 2016-11-09 00:00 +0100

csiph-web