Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1517625
| From | Stephen Boyd <sboyd@codeaurora.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 1/2] clk: pxa mark dummy helper as 'inline' |
| Date | 2016-11-08 23:50 +0100 |
| Message-ID | <sBnnj-7f0-7@gated-at.bofh.it> (permalink) |
| References | <sBg2u-2e5-27@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 11/08, Arnd Bergmann wrote:
> The dummy_clk_set_parent function is marked as 'static' but is
> no longer referenced from the pxa25x clk driver after the last use
> of the RATE_RO_OPS() macro is gone from this file, causing a
> harmless build warning:
>
> In file included from drivers/clk/pxa/clk-pxa25x.c:24:0:
> drivers/clk/pxa/clk-pxa.h:146:12: error: 'dummy_clk_set_parent' defined but not used [-Werror=unused-function]
>
> This marks the functon as 'inline', which lets the compiler simply
> drop it when it gets referenced.
>
> Fixes: 9fe694295098 ("clk: pxa: transfer CPU clock setting from pxa2xx-cpufreq")
I hope I don't rewrite clk-next history... I need some sort of
magic git pre-commit hook that rewrites fixes tags if the hash
changes.
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
Applied to clk-next
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 1/2] clk: pxa mark dummy helper as 'inline' Arnd Bergmann <arnd@arndb.de> - 2016-11-08 16:00 +0100
[PATCH 2/2] clk: pxa: fix pxa2xx_determine_rate return Arnd Bergmann <arnd@arndb.de> - 2016-11-08 16:00 +0100
Re: [PATCH 2/2] clk: pxa: fix pxa2xx_determine_rate return Robert Jarzmik <robert.jarzmik@free.fr> - 2016-11-08 19:10 +0100
Re: [PATCH 2/2] clk: pxa: fix pxa2xx_determine_rate return Arnd Bergmann <arnd@arndb.de> - 2016-11-08 23:30 +0100
Re: [PATCH 2/2] clk: pxa: fix pxa2xx_determine_rate return Robert Jarzmik <robert.jarzmik@free.fr> - 2016-11-09 08:40 +0100
Re: [PATCH 2/2] clk: pxa: fix pxa2xx_determine_rate return Stephen Boyd <sboyd@codeaurora.org> - 2016-11-09 21:10 +0100
Re: [PATCH 1/2] clk: pxa mark dummy helper as 'inline' Robert Jarzmik <robert.jarzmik@free.fr> - 2016-11-08 19:00 +0100
Re: [PATCH 1/2] clk: pxa mark dummy helper as 'inline' Stephen Boyd <sboyd@codeaurora.org> - 2016-11-08 23:50 +0100
Re: [PATCH 1/2] clk: pxa mark dummy helper as 'inline' Arnd Bergmann <arnd@arndb.de> - 2016-11-09 00:00 +0100
csiph-web