Re: [PATCH 1/2] Input: gpio_keys - Also send release events for ABS codes

From	Dmitry Torokhov <dmitry.torokhov@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] Input: gpio_keys - Also send release events for ABS codes
Date	2016-11-09 01:20 +0100
Message-ID	<sBoMp-8k7-1@gated-at.bofh.it> (permalink)
References	<syEul-7r4-11@gated-at.bofh.it> <syEum-7r4-37@gated-at.bofh.it> <szt3P-6jb-11@gated-at.bofh.it> <sA7ND-7nZ-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sat, Nov 05, 2016 at 12:58:00PM +0100, Paul Cercueil wrote:
> On 03/11/2016 17:21, Dmitry Torokhov wrote:
> >On Tue, Nov 01, 2016 at 11:25:03AM +0100, Paul Cercueil wrote:
> >>Right now, the gpio-keys driver is mostly used with EV_KEY event types.
> >>However, this driver (and its devicetree bindings) support specifying
> >>a different input type, like EV_ABS, even though this doesn't work in
> >>practice: "key pressed" events are correctly received and treated, but
> >>"key released" are silently ignored.
> >>
> >>With this commit, keys configured as EV_ABS will inject an event with
> >>the value 0 when released.
> >No, this will break setups like this:
> >
> >gpio0 - ABS_X - 0
> >gpio1 - ABS_X - 1
> >gpio2 - ABS_X - 2
> >...
> >gpio7 - ABS_X - 7
> >
> >- something like a slider built on top of gpios.
> 
> So what would you suggest for the implementation of a hat / d-pad on
> top of GPIOs?

Maybe we should allow specifying "release" value for ABS GPIOs.

Thanks.

-- 
Dmitry

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/2] Make gpio-keys usable as a hat Paul Cercueil <paul@crapouillou.net> - 2016-11-01 11:30 +0100
  [PATCH 2/2] Input: gpio_keys - Set ABS params when using axes Paul Cercueil <paul@crapouillou.net> - 2016-11-01 11:30 +0100
    Re: [PATCH 2/2] Input: gpio_keys - Set ABS params when using axes Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-11-03 17:30 +0100
  [PATCH 1/2] Input: gpio_keys - Also send release events for ABS codes Paul Cercueil <paul@crapouillou.net> - 2016-11-01 11:30 +0100
    Re: [PATCH 1/2] Input: gpio_keys - Also send release events for ABS  codes Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-11-03 17:30 +0100
      Re: [PATCH 1/2] Input: gpio_keys - Also send release events for ABS  codes Paul Cercueil <paul@crapouillou.net> - 2016-11-05 13:00 +0100
        Re: [PATCH 1/2] Input: gpio_keys - Also send release events for ABS  codes Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-11-09 01:20 +0100

csiph-web