Re: [PATCH] checkpatch: fix uninitialized var when run with --no-tree

From	Brian Norris <computersforpeace@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] checkpatch: fix uninitialized var when run with --no-tree
Date	2016-11-09 01:10 +0100
Message-ID	<sBoCJ-8eR-11@gated-at.bofh.it> (permalink)
References	<sxrzb-8iY-1@gated-at.bofh.it> <sxrIR-8mP-3@gated-at.bofh.it> <sBnQm-7DS-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Nov 08, 2016 at 03:10:40PM -0800, Andrew Morton wrote:
> I already have the below.  Good enough?

Sure, good enough. Though it does have the same tiny awkwardness as my
v1.

> From: Jerome Forissier <jerome.forissier@linaro.org>
> Subject: checkpatch: don't try to get maintained status when --no-tree is given
> 
> Fixes the following warning:
> Use of uninitialized value $root in concatenation (.) or string at /path/to/checkpatch.pl line 764.
> 
> Link: http://lkml.kernel.org/r/1476719709-16668-1-git-send-email-jerome.forissier@linaro.org
> Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
> Acked-by: Joe Perches <joe@perches.com>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
> 
>  scripts/checkpatch.pl |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff -puN scripts/checkpatch.pl~checkpatch-dont-try-to-get-maintained-status-when-no-tree-is-given scripts/checkpatch.pl
> --- a/scripts/checkpatch.pl~checkpatch-dont-try-to-get-maintained-status-when-no-tree-is-given
> +++ a/scripts/checkpatch.pl
> @@ -761,7 +761,7 @@ sub seed_camelcase_file {
>  sub is_maintained_obsolete {
>  	my ($filename) = @_;
>  
> -	return 0 if (!(-e "$root/scripts/get_maintainer.pl"));
> +	return 0 if (!$tree || !(-e "$root/scripts/get_maintainer.pl"));
>  
>  	my $status = `perl $root/scripts/get_maintainer.pl --status --nom --nol --nogit --nogit-fallback -f $filename 2>&1`;
>  
> _
> 

FWIW:

Reviewed-by: Brian Norris <computersforpeace@gmail.com>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] checkpatch: fix uninitialized var when run with --no-tree Brian Norris <computersforpeace@gmail.com> - 2016-10-29 04:30 +0200
  Re: [PATCH] checkpatch: fix uninitialized var when run with --no-tree Brian Norris <computersforpeace@gmail.com> - 2016-10-29 04:40 +0200
    Re: [PATCH] checkpatch: fix uninitialized var when run with  --no-tree Andrew Morton <akpm@linux-foundation.org> - 2016-11-09 00:20 +0100
      Re: [PATCH] checkpatch: fix uninitialized var when run with --no-tree Brian Norris <computersforpeace@gmail.com> - 2016-11-09 01:10 +0100

csiph-web