Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1518293
| From | Jiri Benc <jbenc@redhat.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] vxlan: hide unused local variable |
| Date | 2016-11-09 17:30 +0100 |
| Message-ID | <sBDV7-1hG-23@gated-at.bofh.it> (permalink) |
| References | <sAZuG-bB-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Mon, 7 Nov 2016 22:09:07 +0100, Arnd Bergmann wrote:
> A bugfix introduced a harmless warning in v4.9-rc4:
>
> drivers/net/vxlan.c: In function 'vxlan_group_used':
> drivers/net/vxlan.c:947:21: error: unused variable 'sock6' [-Werror=unused-variable]
>
> This hides the variable inside of the same #ifdef that is
> around its user. The extraneous initialization is removed
> at the same time, it was accidentally introduced in the
> same commit.
>
> Fixes: c6fcc4fc5f8b ("vxlan: avoid using stale vxlan socket.")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
I think this should be applied instead of Pravin's patch. It fixes just
the one problem, contains the proper Fixes: tag and addresses net.git.
Acked-by: Jiri Benc <jbenc@redhat.com>
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] vxlan: hide unused local variable Arnd Bergmann <arnd@arndb.de> - 2016-11-07 22:20 +0100 Re: [PATCH] vxlan: hide unused local variable Arnd Bergmann <arnd@arndb.de> - 2016-11-07 23:30 +0100 Re: [PATCH] vxlan: hide unused local variable Jiri Benc <jbenc@redhat.com> - 2016-11-09 17:30 +0100 Re: [PATCH] vxlan: hide unused local variable David Miller <davem@davemloft.net> - 2016-11-10 01:10 +0100
csiph-web