Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1516626

Re: [PATCH] vxlan: hide unused local variable

Show all headers | View raw

On Monday, November 7, 2016 2:16:30 PM CET Pravin Shelar wrote:
> On Monday, November 7, 2016, Arnd Bergmann <arnd@arndb.de> wrote:
> 
> > A bugfix introduced a harmless warning in v4.9-rc4:
> >
> > drivers/net/vxlan.c: In function 'vxlan_group_used':
> > drivers/net/vxlan.c:947:21: error: unused variable 'sock6'
> > [-Werror=unused-variable]
> >
> > This hides the variable inside of the same #ifdef that is
> > around its user. The extraneous initialization is removed
> > at the same time, it was accidentally introduced in the
> > same commit.
> >
> > Fixes: c6fcc4fc5f8b ("vxlan: avoid using stale vxlan socket.")
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de <javascript:;>>
> > ---
> 
> 
> I have already submitted patch to fix this issue.
> 
> https://patchwork.ozlabs.org/patch/691588/

You have tagged those seven patches for net-next which seems
appropriate, but as I wrote above the commit that introduced
it was merged between -rc3 and -rc4, so I think we still need a
fix for v4.9, right?

	Arnd

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] vxlan: hide unused local variable Arnd Bergmann <arnd@arndb.de> - 2016-11-07 22:20 +0100
  Re: [PATCH] vxlan: hide unused local variable Arnd Bergmann <arnd@arndb.de> - 2016-11-07 23:30 +0100
  Re: [PATCH] vxlan: hide unused local variable Jiri Benc <jbenc@redhat.com> - 2016-11-09 17:30 +0100
  Re: [PATCH] vxlan: hide unused local variable David Miller <davem@davemloft.net> - 2016-11-10 01:10 +0100

csiph-web