Re: [PATCH v2] memcg: Prevent memcg caches to be both OFF_SLAB & OBJFREELIST_SLAB

From	Thomas Garnier <thgarnie@google.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] memcg: Prevent memcg caches to be both OFF_SLAB & OBJFREELIST_SLAB
Date	2016-11-07 20:00 +0100
Message-ID	<sAXjc-74X-11@gated-at.bofh.it> (permalink)
References	<sypF0-65O-33@gated-at.bofh.it> <syulk-EP-11@gated-at.bofh.it> <sz6gV-8vT-1@gated-at.bofh.it> <szeo9-55A-5@gated-at.bofh.it> <szwXL-lr-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Nov 3, 2016 at 1:33 PM, Christoph Lameter <cl@linux.com> wrote:
> On Wed, 2 Nov 2016, David Rientjes wrote:
>
>> > Christoph on the first version advised removing invalid flags on the
>> > caller and checking they are correct in kmem_cache_create. The memcg
>> > path putting the wrong flags is through create_cache but I still used
>> > this approach.
>> >
>>
>> I think this is a rather trivial point since it doesn't matter if we clear
>> invalid flags on the caller or in the callee and obviously
>> kmem_cache_create() does it in the callee.
>
> In order to be correct we need to do the following:
>
> kmem_cache_create should check for invalid flags (and that includes
> internal alloocator flgs) being set and refuse to create the slab cache.
>
> memcg needs to call kmem_cache_create without any internal flags.
>

I am not sure that is possible. kmem_cache_create currently check for
possible alias, I assume that it goes against what memcg tries to do.

Separate the changes in two patches might make sense:

 1) Fix the original bug by masking the flags passed to create_cache
 2) Add flags check in kmem_cache_create.

Does it make sense?

> I also want to make sure that there are no other callers that specify
> extraneou flags while we are at it.
>

I will review as many as I can but we might run into surprises (quick
boot on defconfig didn't show anything). That's why having two
different patches might be useful.

-- 
Thomas

Thread

[PATCH v2] memcg: Prevent memcg caches to be both OFF_SLAB & OBJFREELIST_SLAB Thomas Garnier <thgarnie@google.com> - 2016-10-31 19:40 +0100
  Re: [PATCH v2] memcg: Prevent memcg caches to be both OFF_SLAB &  OBJFREELIST_SLAB David Rientjes <rientjes@google.com> - 2016-11-01 00:40 +0100
    Re: [PATCH v2] memcg: Prevent memcg caches to be both OFF_SLAB & OBJFREELIST_SLAB Thomas Garnier <thgarnie@google.com> - 2016-11-02 17:10 +0100
      Re: [PATCH v2] memcg: Prevent memcg caches to be both OFF_SLAB &  OBJFREELIST_SLAB David Rientjes <rientjes@google.com> - 2016-11-03 01:50 +0100
        Re: [PATCH v2] memcg: Prevent memcg caches to be both OFF_SLAB &  OBJFREELIST_SLAB Christoph Lameter <cl@linux.com> - 2016-11-03 21:40 +0100
          Re: [PATCH v2] memcg: Prevent memcg caches to be both OFF_SLAB & OBJFREELIST_SLAB Thomas Garnier <thgarnie@google.com> - 2016-11-07 20:00 +0100
            Re: [PATCH v2] memcg: Prevent memcg caches to be both OFF_SLAB &  OBJFREELIST_SLAB Christoph Lameter <cl@linux.com> - 2016-11-07 20:30 +0100
              Re: [PATCH v2] memcg: Prevent memcg caches to be both OFF_SLAB & OBJFREELIST_SLAB Thomas Garnier <thgarnie@google.com> - 2016-11-07 21:00 +0100

csiph-web