Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1515892
| From | Michael Ellerman <mpe@ellerman.id.au> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: Coding Style: Reverse XMAS tree declarations ? (was Re: [PATCH net-next v6 02/10] dpaa_eth: add support for DPAA Ethernet) |
| Date | 2016-11-07 09:10 +0100 |
| Message-ID | <sANaa-gv-5@gated-at.bofh.it> (permalink) |
| References | <szwl3-8ha-21@gated-at.bofh.it> <szwl3-8ha-23@gated-at.bofh.it> <szwl3-8ha-19@gated-at.bofh.it> <szGDL-6CW-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Joe Perches <joe@perches.com> writes:
> On Thu, 2016-11-03 at 15:58 -0400, David Miller wrote:
>> From: Madalin Bucur <madalin.bucur@nxp.com>
>> Date: Wed, 2 Nov 2016 22:17:26 +0200
>>
>> > This introduces the Freescale Data Path Acceleration Architecture
>> > +static inline size_t bpool_buffer_raw_size(u8 index, u8 cnt)
>> > +{
>> > + u8 i;
>> > + size_t res = DPAA_BP_RAW_SIZE / 2;
>>
>> Always order local variable declarations from longest to shortest line,
>> also know as Reverse Christmas Tree Format.
>
> I think this declaration sorting order is misguided but
> here's a possible change to checkpatch adding a test for it
> that does this test just for net/ and drivers/net/
And arch/powerpc too please.
cheers
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH net-next v6 02/10] dpaa_eth: add support for DPAA Ethernet David Miller <davem@davemloft.net> - 2016-11-03 21:00 +0100
Coding Style: Reverse XMAS tree declarations ? (was Re: [PATCH net-next v6 02/10] dpaa_eth: add support for DPAA Ethernet) Joe Perches <joe@perches.com> - 2016-11-04 08:00 +0100
Re: Coding Style: Reverse XMAS tree declarations ? (was Re: [PATCH net-next v6 02/10] dpaa_eth: add support for DPAA Ethernet) Lino Sanfilippo <lsanfil@marvell.com> - 2016-11-04 12:10 +0100
Re: Coding Style: Reverse XMAS tree declarations ? David Miller <davem@davemloft.net> - 2016-11-04 16:10 +0100
Re: Coding Style: Reverse XMAS tree declarations ? Joe Perches <joe@perches.com> - 2016-11-04 18:50 +0100
Re: Coding Style: Reverse XMAS tree declarations ? Lino Sanfilippo <LinoSanfilippo@gmx.de> - 2016-11-04 21:30 +0100
RE: Coding Style: Reverse XMAS tree declarations ? David Laight <David.Laight@ACULAB.COM> - 2016-11-07 12:10 +0100
Re: Coding Style: Reverse XMAS tree declarations ? (was Re: [PATCH net-next v6 02/10] dpaa_eth: add support for DPAA Ethernet) Randy Dunlap <rdunlap@infradead.org> - 2016-11-04 18:10 +0100
Re: Coding Style: Reverse XMAS tree declarations ? (was Re: [PATCH net-next v6 02/10] dpaa_eth: add support for DPAA Ethernet) David VomLehn <vomlehn@texas.net> - 2016-11-04 22:00 +0100
Re: Coding Style: Reverse XMAS tree declarations ? (was Re: [PATCH net-next v6 02/10] dpaa_eth: add support for DPAA Ethernet) Michael Ellerman <mpe@ellerman.id.au> - 2016-11-07 09:10 +0100
Re: [PATCH net-next v6 02/10] dpaa_eth: add support for DPAA Ethernet David Miller <davem@davemloft.net> - 2016-11-07 17:00 +0100
Re: [PATCH net-next v6 02/10] dpaa_eth: add support for DPAA Ethernet David Miller <davem@davemloft.net> - 2016-11-07 17:40 +0100
RE: [PATCH net-next v6 02/10] dpaa_eth: add support for DPAA Ethernet Madalin-Cristian Bucur <madalin.bucur@nxp.com> - 2016-11-08 00:40 +0100
RE: [PATCH net-next v6 02/10] dpaa_eth: add support for DPAA Ethernet Madalin-Cristian Bucur <madalin.bucur@nxp.com> - 2016-11-08 08:30 +0100
RE: [PATCH net-next v6 02/10] dpaa_eth: add support for DPAA Ethernet Madalin-Cristian Bucur <madalin.bucur@nxp.com> - 2016-11-07 17:00 +0100
RE: [PATCH net-next v6 02/10] dpaa_eth: add support for DPAA Ethernet Madalin-Cristian Bucur <madalin.bucur@nxp.com> - 2016-11-09 18:20 +0100
Re: [PATCH net-next v6 02/10] dpaa_eth: add support for DPAA Ethernet David Miller <davem@davemloft.net> - 2016-11-09 18:20 +0100
csiph-web