Re: [PATCH] staging: lustre: o2iblnd: replace space indentation with tabs

From	Greg KH <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] staging: lustre: o2iblnd: replace space indentation with tabs
Date	2016-11-07 07:50 +0100
Message-ID	<sALUK-7ND-13@gated-at.bofh.it> (permalink)
References	<szWIx-mz-5@gated-at.bofh.it> <sAHxL-55x-7@gated-at.bofh.it> <sAIau-5kG-7@gated-at.bofh.it> <sAJgj-61l-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Nov 07, 2016 at 03:55:36AM +0000, James Simmons wrote:
> 
> > On Mon, 2016-11-07 at 02:02 +0000, James Simmons wrote:
> > > > This patch fixes all CODE_INDENT checkpatch errors in o2iblnd.
> > > Reviewed-by: James Simmons <jsimmons@infradead.org>
> > []
> > > > diff --git a/drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c b/drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c
> > []
> > > > @@ -1637,7 +1637,7 @@ int kiblnd_fmr_pool_map(struct kib_fmr_poolset *fps, struct kib_tx *tx,
> > > >  {
> > > >  	__u64 *pages = tx->tx_pages;
> > > >  	bool is_rx = (rd != tx->tx_rd);
> > > > -        bool tx_pages_mapped = 0;
> > > > +	bool tx_pages_mapped = 0;
> > 
> > It's generally better to use bool assignments to true/false not 1/0.
> 
> Nicholas can you resubmit with tx_pages_mapped = false. Looking at the 
> lustre code its the only place like this. Thanks for pointing this out.

No, make it a separate patch, don't change code when you are just
changing indentation in the same patch.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] staging: lustre: o2iblnd: replace space indentation with tabs Nicholas Hanley <nicholasjhanley@gmail.com> - 2016-11-05 01:10 +0100
  Re: [PATCH] staging: lustre: o2iblnd: replace space indentation  with tabs Joe Perches <joe@perches.com> - 2016-11-07 03:50 +0100
    Re: [PATCH] staging: lustre: o2iblnd: replace space indentation with  tabs James Simmons <jsimmons@infradead.org> - 2016-11-07 05:00 +0100
      Re: [PATCH] staging: lustre: o2iblnd: replace space indentation with  tabs Greg KH <gregkh@linuxfoundation.org> - 2016-11-07 07:50 +0100

csiph-web