Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1515829
| From | Joe Perches <joe@perches.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] staging: lustre: o2iblnd: replace space indentation with tabs |
| Date | 2016-11-07 03:50 +0100 |
| Message-ID | <sAIau-5kG-7@gated-at.bofh.it> (permalink) |
| References | <szWIx-mz-5@gated-at.bofh.it> <sAHxL-55x-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Mon, 2016-11-07 at 02:02 +0000, James Simmons wrote:
> > This patch fixes all CODE_INDENT checkpatch errors in o2iblnd.
> Reviewed-by: James Simmons <jsimmons@infradead.org>
[]
> > diff --git a/drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c b/drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c
[]
> > @@ -1637,7 +1637,7 @@ int kiblnd_fmr_pool_map(struct kib_fmr_poolset *fps, struct kib_tx *tx,
> > {
> > __u64 *pages = tx->tx_pages;
> > bool is_rx = (rd != tx->tx_rd);
> > - bool tx_pages_mapped = 0;
> > + bool tx_pages_mapped = 0;
It's generally better to use bool assignments to true/false not 1/0.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] staging: lustre: o2iblnd: replace space indentation with tabs Nicholas Hanley <nicholasjhanley@gmail.com> - 2016-11-05 01:10 +0100
Re: [PATCH] staging: lustre: o2iblnd: replace space indentation with tabs Joe Perches <joe@perches.com> - 2016-11-07 03:50 +0100
Re: [PATCH] staging: lustre: o2iblnd: replace space indentation with tabs James Simmons <jsimmons@infradead.org> - 2016-11-07 05:00 +0100
Re: [PATCH] staging: lustre: o2iblnd: replace space indentation with tabs Greg KH <gregkh@linuxfoundation.org> - 2016-11-07 07:50 +0100
csiph-web