Re: [PATCH v7 2/2] x86/apic: x2apic write eoi msr notrace

Path	csiph.com!goblin2!goblin.stu.neva.ru!aioe.org!gothmog.csi.it!bofh.it!news.nic.it!robomod
From	Wanpeng Li <kernellwp@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v7 2/2] x86/apic: x2apic write eoi msr notrace
Date	Mon, 07 Nov 2016 05:40:02 +0100
Message-ID	<sAJSW-6w9-7@gated-at.bofh.it> (permalink)
References	<sy9JU-41p-5@gated-at.bofh.it> <sy9JU-41p-15@gated-at.bofh.it> <szb6W-384-11@gated-at.bofh.it>
X-Original-To	Borislav Petkov <bp@alien8.de>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=ljAUoq8KFmxYrMpCrgM3H/xggckUTnovj/5CRz7kRro=; b=dfNxprVsjGzMnjaE5Ve2aZBg+BVLz8C/OhwPk/gAXuTX/fOx5+mZCt1AOkYlEEAqmr KlNBfd3+HCrFrWolE/+yz8noQC2qZDG4taNasfLL9DLvbCS/mgPx2Nci1QKR+SvSx9yZ bvEWDdb8a+dddgydSl82N3Oa0CyZIdyS/bGF6SQbkF+NC/gmyCi/ezeRPniMwldGOXXW Q8gGxH+OZo4GOt95A+0Ze27qG8ljTGyBjwKWmuqt9d8NzJVWjPadqhFrAldAfnRKk8tK kKbbXrvxgae8zbDlk81gLsZRlB9AW1qp2cpWwU19tm+SGJX8UwGjZhmrsZwgDkNNDDsk pxxA==
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=ljAUoq8KFmxYrMpCrgM3H/xggckUTnovj/5CRz7kRro=; b=m7hwDOR0Atp18LiIZj0EP3n1sGkAjD6SyI/oao7uKH+f7q8OyN/IlA1VTCAu8wo2xS QI1WGRvOZh9a81A+WegFHzhV9Gk2pDczIoCL0ZocXMbMYySOeZxPQl5BVmwU75jjwjBx H5mLIyZPO1zCuQTMMCSiNeAx9jX62zC4fG5w2+r4e7LroM2bn76GgCQs58eHYl/Nem3m KGb+gYrm768rqNIPjYArOXKHcamIYaAuYRXDYswbo5+G+z4786BVfgbL0STTNdHlA4CI Hfn8/aAk/hztwCCIgNZeABhcRFOI2Pa0qks3IS866wj6d90jUxDiPFPnVyvwMi75/F9E gmtQ==
X-Gm-Message-State	ABUngvepsnR7men60diJiOOS8XftTo+46viL/iauws9tnrsiTHnSc7j30/nyB61TFjv13Wyi8heB3tkKrjqUFg==
X-Received	by 10.194.157.41 with SMTP id wj9mr221773wjb.160.1478487164142; Sun, 06 Nov 2016 18:52:44 -0800 (PST)
MIME-Version	1.0
Content-Type	text/plain; charset=UTF-8
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	38
Organization	linux.* mail to news gateway
X-Original-Cc	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, kvm <kvm@vger.kernel.org>, Ingo Molnar <mingo@kernel.org>, Mike Galbraith <efault@gmx.de>, Peter Zijlstra <peterz@infradead.org>, Thomas Gleixner <tglx@linutronix.de>, Paolo Bonzini <pbonzini@redhat.com>, Wanpeng Li <wanpeng.li@hotmail.com>
X-Original-Date	Mon, 7 Nov 2016 10:52:43 +0800
X-Original-Message-ID	<CANRm+Cwd+6xheteake+ZZcZvqVzE_yu2LpP5nsr1t=M7nYTccg@mail.gmail.com>
X-Original-References	<1477877822-4437-1-git-send-email-wanpeng.li@hotmail.com> <1477877822-4437-3-git-send-email-wanpeng.li@hotmail.com> <20161102211015.qsbwpgmb7eybztc5@pd.tnic>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1515845

Show key headers only | View raw

2016-11-03 5:10 GMT+08:00 Borislav Petkov <bp@alien8.de>:
> On Mon, Oct 31, 2016 at 09:37:02AM +0800, Wanpeng Li wrote:
>> From: Wanpeng Li <wanpeng.li@hotmail.com>
>>
>> | RCU used illegally from idle CPU!
>> | rcu_scheduler_active = 1, debug_locks = 0
>> | RCU used illegally from extended quiescent state!
>> | no locks held by swapper/1/0.
>> |
>> |  [<ffffffff9d492b95>] do_trace_write_msr+0x135/0x140
>> |  [<ffffffff9d06f860>] native_write_msr+0x20/0x30
>> |  [<ffffffff9d065fad>] native_apic_msr_eoi_write+0x1d/0x30
>> |  [<ffffffff9d05bd1d>] smp_reschedule_interrupt+0x1d/0x30
>> |  [<ffffffff9d8daec6>] reschedule_interrupt+0x96/0xa0
>
> Please remove the text between [] and the offsets after "+..." - those
> are useless in a commit message.
>
>> Reschedule interrupt may be called in cpu idle state. This causes lockdep
>
> s/cpu/CPU/
>
>> check warning above.
>>
>> As Peterz pointed out:
>>
>> | So now we're making a very frequent interrupt slower because of debug
>> | code.
>> |
>> | The thing is, many many smp_reschedule_interrupt() invocations don't
>> | actually execute anything much at all and are only send to tickle the
>
> s/send/sent/

I will send a new version to clean it up.

Regards,
Wanpeng Li

Thread

[PATCH v7 0/2] x86/apic: x2apic write eoi msr notrace Wanpeng Li <kernellwp@gmail.com> - 2016-10-31 02:40 +0100
  [PATCH v7 1/2] x86/msr: Add write msr notrace  Wanpeng Li <kernellwp@gmail.com> - 2016-10-31 02:40 +0100
    Re: [PATCH v7 1/2] x86/msr: Add write msr notrace Borislav Petkov <bp@alien8.de> - 2016-11-02 22:20 +0100
  [PATCH v7 2/2] x86/apic: x2apic write eoi msr notrace Wanpeng Li <kernellwp@gmail.com> - 2016-10-31 02:40 +0100
    Re: [PATCH v7 2/2] x86/apic: x2apic write eoi msr notrace Borislav Petkov <bp@alien8.de> - 2016-11-02 22:20 +0100
      Re: [PATCH v7 2/2] x86/apic: x2apic write eoi msr notrace Wanpeng Li <kernellwp@gmail.com> - 2016-11-07 05:40 +0100
  Re: [PATCH v7 0/2] x86/apic: x2apic write eoi msr notrace Borislav Petkov <bp@alien8.de> - 2016-11-02 22:20 +0100

csiph-web