Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1469082

Re: [PATCH v2 2/4] ARM: dts: exynos: Use 'hpd-gpios' instead of 'hpd-gpio'

Show all headers | View raw

On 08/24/2016 04:25 AM, Milo Kim wrote:
> This patch enables getting a HPD GPIO descriptor quickly.
> The exynos-hdmi driver uses "hpd" for HDMI hot plug detection.
>
> 	static int hdmi_resources_init(struct hdmi_context *hdata)
> 	{
> 		...
> 		hdata->hpd_gpio = devm_gpiod_get(dev, "hpd", GPIOD_IN);
> 		...
> 	}
>
> This calls 'of_find_gpio()' and it generates the GPIO consumer ID by referring
> GPIO suffix. So 'hpd-gpios' is preferred on getting a GPIO descriptor.
>
> However, if the device tree uses 'hpd-gpio', then the exynos-hdmi driver
> always retries to get a GPIO descriptor because the first GPIO suffix is not
> 'gpio' but 'gpios'. So you always see the debug message below.
>
> 	of_get_named_gpiod_flags: can't parse 'hpd-gpios' property of node '/soc/hdmi@14530000[0]'
>
> Use the preferred property, 'hpd-gpios' instead of 'hpd-gpio'.
>
> Acked-by: Rob Herring <robh@kernel.org>
> Cc: Kukjin Kim <kgene@kernel.org>
> Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Inki Dae <inki.dae@samsung.com>
> Cc: Joonyoung Shim <jy0922.shim@samsung.com>
> Cc: Seung-Woo Kim <sw0312.kim@samsung.com>
> Cc: Kyungmin Park <kyungmin.park@samsung.com>
> Cc: devicetree@vger.kernel.org
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-samsung-soc@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Cc: dri-devel@lists.freedesktop.org
> Signed-off-by: Milo Kim <woogyom.kim@gmail.com>
I am not sure if this long Cc list is necessary.
Anyway:

Reviewed-by: Andrzej Hajda <a.hajda@samsung.com>
--
Regards
Andrzej

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/4] ARM: dts: exynos: Enable HDMI in Arndale Octa board Milo Kim <woogyom.kim@gmail.com> - 2016-08-24 04:30 +0200
  [PATCH v2 4/4] gpu: drm: exynos_hdmi: Use consolidated function on binding PHY DT property Milo Kim <woogyom.kim@gmail.com> - 2016-08-24 04:30 +0200
    Re: [PATCH v2 4/4] gpu: drm: exynos_hdmi: Use consolidated function on  binding PHY DT property Andrzej Hajda <a.hajda@samsung.com> - 2016-08-24 08:00 +0200
  [PATCH v2 2/4] ARM: dts: exynos: Use 'hpd-gpios' instead of 'hpd-gpio' Milo Kim <woogyom.kim@gmail.com> - 2016-08-24 04:30 +0200
    Re: [PATCH v2 2/4] ARM: dts: exynos: Use 'hpd-gpios' instead of  'hpd-gpio' Andrzej Hajda <a.hajda@samsung.com> - 2016-08-24 07:40 +0200
  [PATCH v2 1/4] ARM: dts: exynos: Enable HDMI for Arndale Octa board Milo Kim <woogyom.kim@gmail.com> - 2016-08-24 04:30 +0200
    Re: [PATCH v2 1/4] ARM: dts: exynos: Enable HDMI for Arndale Octa board Andrzej Hajda <a.hajda@samsung.com> - 2016-08-24 07:30 +0200
      Re: [PATCH v2 1/4] ARM: dts: exynos: Enable HDMI for Arndale Octa  board Milo Kim <woogyom.kim@gmail.com> - 2016-08-24 09:20 +0200
  [PATCH v2 3/4] gpu: drm: exynos_hdmi: Use consolidated function on binding DDC DT property Milo Kim <woogyom.kim@gmail.com> - 2016-08-24 04:30 +0200
    Re: [PATCH v2 3/4] gpu: drm: exynos_hdmi: Use consolidated function on  binding DDC DT property Andrzej Hajda <a.hajda@samsung.com> - 2016-08-24 08:00 +0200
      Re: [PATCH v2 3/4] gpu: drm: exynos_hdmi: Use consolidated function  on binding DDC DT property Milo Kim <woogyom.kim@gmail.com> - 2016-08-24 09:30 +0200

csiph-web