Re: [PATCH] net: phy: micrel: remove suspend/resume

From	Florian Fainelli <f.fainelli@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] net: phy: micrel: remove suspend/resume
Date	2016-08-23 21:10 +0200
Message-ID	<s9pfc-880-25@gated-at.bofh.it> (permalink)
References	<s9pfc-880-27@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

+others,

On 08/23/2016 04:13 AM, Christophe Leroy wrote:
> In ERRATA DS80000700A dated 05 May 2016, Microship recommends to
> not use software power down mode on KSZ8041 family.

s/Microship/Microchip/

> They say they have no plan to fix this ERRATA in future releases.

The errata applies to specific revisions, is this revision present in
the lower 4 bits of the MII_PHYSID2 register such that it could be used
to key the disabling of the power down?

> 
> http://ww1.microchip.com/downloads/en/DeviceDoc/80000700A.pdf
> 
> Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
> ---
>  drivers/net/phy/micrel.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c
> index 053e879..f456c55 100644
> --- a/drivers/net/phy/micrel.c
> +++ b/drivers/net/phy/micrel.c
> @@ -837,8 +837,6 @@ static struct phy_driver ksphy_driver[] = {
>  	.get_sset_count = kszphy_get_sset_count,
>  	.get_strings	= kszphy_get_strings,
>  	.get_stats	= kszphy_get_stats,
> -	.suspend	= genphy_suspend,
> -	.resume		= genphy_resume,
>  }, {
>  	.phy_id		= PHY_ID_KSZ8041RNLI,
>  	.phy_id_mask	= MICREL_PHY_ID_MASK,
> @@ -856,8 +854,6 @@ static struct phy_driver ksphy_driver[] = {
>  	.get_sset_count = kszphy_get_sset_count,
>  	.get_strings	= kszphy_get_strings,
>  	.get_stats	= kszphy_get_stats,
> -	.suspend	= genphy_suspend,
> -	.resume		= genphy_resume,
>  }, {
>  	.phy_id		= PHY_ID_KSZ8051,
>  	.phy_id_mask	= MICREL_PHY_ID_MASK,
> 


-- 
Florian

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] net: phy: micrel: remove suspend/resume Florian Fainelli <f.fainelli@gmail.com> - 2016-08-23 21:10 +0200
  Re: [PATCH] net: phy: micrel: remove suspend/resume Xander Huff <xander.huff@ni.com> - 2016-08-24 00:10 +0200
  Re: [PATCH] net: phy: micrel: remove suspend/resume Christophe Leroy <christophe.leroy@c-s.fr> - 2016-08-24 16:20 +0200

csiph-web