Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1468744

Re: [PATCH 4/7] fs: make remaining filesystems use .rename2

Show all headers | View raw

I looked at this in today's linux-next and ran a few renames through...

Acked-by:: Mike Marshall <hubcap@omnibond.com>

On Tue, Aug 23, 2016 at 10:47 AM, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
> On Tue, Aug 23, 2016 at 04:05:29PM +0200, Miklos Szeredi wrote:
>> This is trivial to do:
>>
>>  - add flags argument to foo_rename()
>>  - check if flags is zero
>>  - assign foo_rename() to .rename2 instead of .rename
>>
>> This doesn't mean it's impossible to support RENAME_NOREPLACE for these
>> filesystems, but it is not trivial, like for local filesystems.
>> RENAME_NOREPLACE must guarantee atomicity (i.e. it shouldn't be possible
>> for a file to be created on one host while it is overwritten by rename on
>> another host).
>>
>> Filesystems converted:
>>
>> 9p, afs, ceph, coda, ecryptfs, exofs, kernfs, lustre, ncpfs, nfs, ocfs2,
>> orangefs.
>>
>> After this, we can get rid of the duplicate interfaces for rename.
>>
>> Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
>> Cc: Eric Van Hensbergen <ericvh@gmail.com>
>> Cc: David Howells <dhowells@redhat.com>
>> Cc: Ilya Dryomov <idryomov@gmail.com>
>> Cc: Jan Harkes <jaharkes@cs.cmu.edu>
>> Cc: Tyler Hicks <tyhicks@canonical.com>
>> Cc: Boaz Harrosh <ooo@electrozaur.com>
>> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>> Cc: Oleg Drokin <oleg.drokin@intel.com>
>> Cc: Trond Myklebust <trond.myklebust@primarydata.com>
>> Cc: Mark Fasheh <mfasheh@suse.com>
>> Cc: Mike Marshall <hubcap@omnibond.com>
>
> Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 4/7] fs: make remaining filesystems use .rename2 Miklos Szeredi <mszeredi@redhat.com> - 2016-08-23 16:20 +0200
  Re: [PATCH 4/7] fs: make remaining filesystems use .rename2 Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-08-23 16:50 +0200
    Re: [PATCH 4/7] fs: make remaining filesystems use .rename2 Mike Marshall <hubcap@omnibond.com> - 2016-08-23 19:40 +0200
  Re: [PATCH 4/7] fs: make remaining filesystems use .rename2 David Howells <dhowells@redhat.com> - 2016-08-23 17:50 +0200
  Re: [PATCH 4/7] fs: make remaining filesystems use .rename2 Boaz Harrosh <ooo@electrozaur.com> - 2016-08-23 18:30 +0200
    Re: [PATCH 4/7] fs: make remaining filesystems use .rename2 Boaz Harrosh <openosd@gmail.com> - 2016-08-23 18:30 +0200

csiph-web