Re: [PATCH 4/7] fs: make remaining filesystems use .rename2

From	David Howells <dhowells@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 4/7] fs: make remaining filesystems use .rename2
Date	2016-08-23 17:50 +0200
Message-ID	<s9m7D-5U4-5@gated-at.bofh.it> (permalink)
References	<s9kIx-563-3@gated-at.bofh.it> <s9kyS-52F-33@gated-at.bofh.it> <s9kIx-563-3@gated-at.bofh.it>
Organization	Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903

Show all headers | View raw

Miklos Szeredi <mszeredi@redhat.com> wrote:

> This is trivial to do:
> 
>  - add flags argument to foo_rename()
>  - check if flags is zero
>  - assign foo_rename() to .rename2 instead of .rename
> 
> This doesn't mean it's impossible to support RENAME_NOREPLACE for these
> filesystems, but it is not trivial, like for local filesystems.
> RENAME_NOREPLACE must guarantee atomicity (i.e. it shouldn't be possible
> for a file to be created on one host while it is overwritten by rename on
> another host).
> 
> Filesystems converted:
> 
> 9p, afs, ceph, coda, ecryptfs, exofs, kernfs, lustre, ncpfs, nfs, ocfs2,
> orangefs.
> 
> After this, we can get rid of the duplicate interfaces for rename.
> 
> Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
> Cc: Eric Van Hensbergen <ericvh@gmail.com>
> Cc: Ilya Dryomov <idryomov@gmail.com>
> Cc: Jan Harkes <jaharkes@cs.cmu.edu>
> Cc: Tyler Hicks <tyhicks@canonical.com>
> Cc: Boaz Harrosh <ooo@electrozaur.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Oleg Drokin <oleg.drokin@intel.com>
> Cc: Trond Myklebust <trond.myklebust@primarydata.com>
> Cc: Mark Fasheh <mfasheh@suse.com>
> Cc: Mike Marshall <hubcap@omnibond.com>

Acked-by: David Howells <dhowells@redhat.com> [AFS]

Thread

[PATCH 4/7] fs: make remaining filesystems use .rename2 Miklos Szeredi <mszeredi@redhat.com> - 2016-08-23 16:20 +0200
  Re: [PATCH 4/7] fs: make remaining filesystems use .rename2 Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-08-23 16:50 +0200
    Re: [PATCH 4/7] fs: make remaining filesystems use .rename2 Mike Marshall <hubcap@omnibond.com> - 2016-08-23 19:40 +0200
  Re: [PATCH 4/7] fs: make remaining filesystems use .rename2 David Howells <dhowells@redhat.com> - 2016-08-23 17:50 +0200
  Re: [PATCH 4/7] fs: make remaining filesystems use .rename2 Boaz Harrosh <ooo@electrozaur.com> - 2016-08-23 18:30 +0200
    Re: [PATCH 4/7] fs: make remaining filesystems use .rename2 Boaz Harrosh <openosd@gmail.com> - 2016-08-23 18:30 +0200

csiph-web