Re: [RESEND] [PATCH v2 2/4] dt-bindings: Add jdi lt070me05000 panel bindings

Path	csiph.com!news.redatomik.org!aioe.org!bofh.it!news.nic.it!robomod
From	Thierry Reding <thierry.reding@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [RESEND] [PATCH v2 2/4] dt-bindings: Add jdi lt070me05000 panel bindings
Date	Wed, 24 Aug 2016 14:40:02 +0200
Message-ID	<s9FDk-2fA-3@gated-at.bofh.it> (permalink)
References	<s10GZ-1Mw-13@gated-at.bofh.it> <s110l-1W3-9@gated-at.bofh.it> <s9F0B-1JN-31@gated-at.bofh.it> <s9FtE-2aP-55@gated-at.bofh.it>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=964/RkeojC0TlHI+m0qeb5D4E8L7EWZwVEMFmzqo7gg=; b=rBBywPbkCWG04upRnhRv4Hwh/EVonMXQrIZabWukVhXBWNBCoawxxXUrF1JYme3xJz Me7TBf5Wh4XqHr79BUdpLyt9BDoMJGw4UKUyDsICXwKgz6YAHNBdm9SdS0SV2z7pjlTX /wXhPtjgZ4gMomNGUfXPHcwWTEuOGXVZNKAJOiPLpe4sFNkItStRTq+IJ+Ip78+UnMyo l58aTseYQSXmQYG9lwN7g4cCgIRXdl/tBvzHVpQ/WL6FrO0yoHLR6Xzdnan+jLU5VbOC gx6WLqyThXHe2oerd9/4TCwb0vTYHQjNHaLFi+P2R6dAyVUfxBFuNOmivbtmWVkzTxZe R8Sw==
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=964/RkeojC0TlHI+m0qeb5D4E8L7EWZwVEMFmzqo7gg=; b=PQ7j/1zBKcWs9d3cC7LDSvy3HggYprBQlzWZZTI3tPvtQjZOb/pp5BGMHICYzEO10Y /X+EHpJkR4iOgut1oEVAjLQmQLfQ+7XMg9xQdGBNBVrf361eXZcnJRNyzx/efMNyUEfa fPMyEpozEoX2BMgWR5atUYdPCuBA7dQyol23sDc3cXLKNeBqjGdO0mh0g1zYswLwiJuC RyrCaE6FOOCZ3UfriImaSf0Tzjigvtf4P+zn9EEylpzPe1aZYm8O9MDJmzVbWleD5RSD igR9IrgNOI6v3d7LvgAOTviSji33UtVRiVD1fQTKRKdsc5TY0wsldUcEykK5rcLAkanm JGAA==
X-Gm-Message-State	AEkoousXKTvglRqTGwRJ9nZuYPZL7w4k4g09lLKPzJe52+P37c5MTvsxAd8HAG1NBT8t2Q==
X-Received	by 10.194.156.195 with SMTP id wg3mr2547380wjb.152.1472042136748; Wed, 24 Aug 2016 05:35:36 -0700 (PDT)
MIME-Version	1.0
Content-Type	multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="f2QGlHpHGjS2mn6Y"
Content-Disposition	inline
User-Agent	Mutt/1.6.2 (2016-07-01)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	46
Organization	linux.* mail to news gateway
X-Original-Cc	Archit Taneja <archit.taneja@gmail.com>, John Stultz <john.stultz@linaro.org>, Sumit Semwal <sumit.semwal@linaro.org>, David Airlie <airlied@linux.ie>, Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, "open list:DRM PANEL DRIVERS" <dri-devel@lists.freedesktop.org>, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>, open list <linux-kernel@vger.kernel.org>
X-Original-Date	Wed, 24 Aug 2016 14:35:34 +0200
X-Original-Message-ID	<20160824123534.GB3714@ulmo.ba.sec>
X-Original-References	<1469978126-925-1-git-send-email-simhavcs@gmail.com> <1469978126-925-2-git-send-email-simhavcs@gmail.com> <20160824115639.GC3169@ulmo.ba.sec> <CAGWqDJ6HuoHP5ygEG-SWUhaUqOjnzTCZb=xyO_pu8xXXHnq5Aw@mail.gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1469384

Show key headers only | View raw

[Multipart message — attachments visible in raw view] - view raw

On Wed, Aug 24, 2016 at 05:53:00PM +0530, Vinay Simha wrote:
> if we do not set the polarity to 8mA, panel will have gibberish display.
> (information to set 8mA is available only in
> nexus7-msm-flo-3.4-lollipop-release_dsi kernel nx7 release)
> 
> i will add this
> reset-gpios = <&tlmm_pinmux 54 GPIO_ACTIVE_LOW>;

I don't think that will work with the current driver, because the GPIO
subsystem will automatically invert the value for you. Currently the
panel driver sets the GPIO value to 0 to assert the reset. With the
GPIO_ACTIVE_LOW flag you'd end up setting the actual level of the GPIO
to high, which is going to deassert. So I think if you make the above
change (which I think is the right thing to do), you'll also have to
update the driver to use high-active logic.

Thierry

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [RESEND] [PATCH v2 2/4] dt-bindings: Add jdi lt070me05000 panel  bindings Thierry Reding <thierry.reding@gmail.com> - 2016-08-24 14:00 +0200
  Re: [RESEND] [PATCH v2 2/4] dt-bindings: Add jdi lt070me05000 panel bindings Vinay Simha <simhavcs@gmail.com> - 2016-08-24 14:30 +0200
    Re: [RESEND] [PATCH v2 2/4] dt-bindings: Add jdi lt070me05000 panel  bindings Thierry Reding <thierry.reding@gmail.com> - 2016-08-24 14:40 +0200

csiph-web