Re: [RESEND] [PATCH v2 2/4] dt-bindings: Add jdi lt070me05000 panel bindings

From	Thierry Reding <thierry.reding@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [RESEND] [PATCH v2 2/4] dt-bindings: Add jdi lt070me05000 panel bindings
Date	2016-08-24 14:40 +0200
Message-ID	<s9FDk-2fA-3@gated-at.bofh.it> (permalink)
References	<s10GZ-1Mw-13@gated-at.bofh.it> <s110l-1W3-9@gated-at.bofh.it> <s9F0B-1JN-31@gated-at.bofh.it> <s9FtE-2aP-55@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Wed, Aug 24, 2016 at 05:53:00PM +0530, Vinay Simha wrote:
> if we do not set the polarity to 8mA, panel will have gibberish display.
> (information to set 8mA is available only in
> nexus7-msm-flo-3.4-lollipop-release_dsi kernel nx7 release)
> 
> i will add this
> reset-gpios = <&tlmm_pinmux 54 GPIO_ACTIVE_LOW>;

I don't think that will work with the current driver, because the GPIO
subsystem will automatically invert the value for you. Currently the
panel driver sets the GPIO value to 0 to assert the reset. With the
GPIO_ACTIVE_LOW flag you'd end up setting the actual level of the GPIO
to high, which is going to deassert. So I think if you make the above
change (which I think is the right thing to do), you'll also have to
update the driver to use high-active logic.

Thierry

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [RESEND] [PATCH v2 2/4] dt-bindings: Add jdi lt070me05000 panel  bindings Thierry Reding <thierry.reding@gmail.com> - 2016-08-24 14:00 +0200
  Re: [RESEND] [PATCH v2 2/4] dt-bindings: Add jdi lt070me05000 panel bindings Vinay Simha <simhavcs@gmail.com> - 2016-08-24 14:30 +0200
    Re: [RESEND] [PATCH v2 2/4] dt-bindings: Add jdi lt070me05000 panel  bindings Thierry Reding <thierry.reding@gmail.com> - 2016-08-24 14:40 +0200

csiph-web