Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1469329

[PATCH v2 6/8] hisi_sas: fail tmf task prep when port detached

From John Garry <john.garry@huawei.com>
Newsgroups linux.kernel
Subject [PATCH v2 6/8] hisi_sas: fail tmf task prep when port detached
Date 2016-08-24 13:00 +0200
Message-ID <s9E4y-17j-15@gated-at.bofh.it> (permalink)
References <s9DUR-13q-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


When the port is detached we cannot execute a TMF,
as there can be no device attached to the port.

Signed-off-by: John Garry <john.garry@huawei.com>
---
 drivers/scsi/hisi_sas/hisi_sas_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/hisi_sas/hisi_sas_main.c b/drivers/scsi/hisi_sas/hisi_sas_main.c
index 280a19d..73f581f 100644
--- a/drivers/scsi/hisi_sas/hisi_sas_main.c
+++ b/drivers/scsi/hisi_sas/hisi_sas_main.c
@@ -204,7 +204,7 @@ static int hisi_sas_task_prep(struct sas_task *task, struct hisi_hba *hisi_hba,
 		return rc;
 	}
 	port = device->port->lldd_port;
-	if (port && !port->port_attached && !tmf) {
+	if (port && !port->port_attached) {
 		if (sas_protocol_ata(task->task_proto)) {
 			struct task_status_struct *ts = &task->task_status;
 
-- 
1.9.1

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v2 0/8] hisi_sas internal abort support John Garry <john.garry@huawei.com> - 2016-08-24 12:50 +0200
  [PATCH v2 7/8] hisi_sas: add TMF success check John Garry <john.garry@huawei.com> - 2016-08-24 12:50 +0200
  [PATCH v2 6/8] hisi_sas: fail tmf task prep when port detached John Garry <john.garry@huawei.com> - 2016-08-24 13:00 +0200
  [PATCH v2 8/8] hisi_sas: update version to 1.6 John Garry <john.garry@huawei.com> - 2016-08-24 13:00 +0200
  [PATCH v2 5/8] hisi_sas: add v2 hw slot complete internal abort support John Garry <john.garry@huawei.com> - 2016-08-24 13:00 +0200
    Re: [PATCH v2 5/8] hisi_sas: add v2 hw slot complete internal abort  support Hannes Reinecke <hare@suse.de> - 2016-08-24 15:10 +0200
      Re: [PATCH v2 5/8] hisi_sas: add v2 hw slot complete internal abort  support John Garry <john.garry@huawei.com> - 2016-08-24 16:10 +0200
        Re: [PATCH v2 5/8] hisi_sas: add v2 hw slot complete internal abort  support Hannes Reinecke <hare@suse.de> - 2016-08-24 16:40 +0200

csiph-web