Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1469327
| From | John Garry <john.garry@huawei.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH v2 7/8] hisi_sas: add TMF success check |
| Date | 2016-08-24 12:50 +0200 |
| Message-ID | <s9DUS-13q-23@gated-at.bofh.it> (permalink) |
| References | <s9DUR-13q-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
When a tmf is issued, various response codes can be
returned from the target. For a query tmf the
response may be TMF_RESP_FUNC_COMPLETE or
TMF_RESP_FUNC_SUCC.
Add a condition for TMF_RESP_FUNC_SUCC to
hisi_sas_exec_internal_tmf_task().
This affects query tmf, as the result is success
the returned value was for failure.
Signed-off-by: John Garry <john.garry@huawei.com>
---
drivers/scsi/hisi_sas/hisi_sas_main.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/scsi/hisi_sas/hisi_sas_main.c b/drivers/scsi/hisi_sas/hisi_sas_main.c
index 73f581f..85c73d3 100644
--- a/drivers/scsi/hisi_sas/hisi_sas_main.c
+++ b/drivers/scsi/hisi_sas/hisi_sas_main.c
@@ -744,6 +744,12 @@ static int hisi_sas_exec_internal_tmf_task(struct domain_device *device,
}
if (task->task_status.resp == SAS_TASK_COMPLETE &&
+ task->task_status.stat == TMF_RESP_FUNC_SUCC) {
+ res = TMF_RESP_FUNC_SUCC;
+ break;
+ }
+
+ if (task->task_status.resp == SAS_TASK_COMPLETE &&
task->task_status.stat == SAS_DATA_UNDERRUN) {
/* no error, but return the number of bytes of
* underrun
--
1.9.1
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2 0/8] hisi_sas internal abort support John Garry <john.garry@huawei.com> - 2016-08-24 12:50 +0200
[PATCH v2 7/8] hisi_sas: add TMF success check John Garry <john.garry@huawei.com> - 2016-08-24 12:50 +0200
[PATCH v2 6/8] hisi_sas: fail tmf task prep when port detached John Garry <john.garry@huawei.com> - 2016-08-24 13:00 +0200
[PATCH v2 8/8] hisi_sas: update version to 1.6 John Garry <john.garry@huawei.com> - 2016-08-24 13:00 +0200
[PATCH v2 5/8] hisi_sas: add v2 hw slot complete internal abort support John Garry <john.garry@huawei.com> - 2016-08-24 13:00 +0200
Re: [PATCH v2 5/8] hisi_sas: add v2 hw slot complete internal abort support Hannes Reinecke <hare@suse.de> - 2016-08-24 15:10 +0200
Re: [PATCH v2 5/8] hisi_sas: add v2 hw slot complete internal abort support John Garry <john.garry@huawei.com> - 2016-08-24 16:10 +0200
Re: [PATCH v2 5/8] hisi_sas: add v2 hw slot complete internal abort support Hannes Reinecke <hare@suse.de> - 2016-08-24 16:40 +0200
csiph-web