Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1467865

Re: [PATCH 0/7] staging: lustre: last missing patches for lustre 2.6

Show all headers | View raw

On Mon, 2016-08-22 at 18:41 +0100, James Simmons wrote:
> On Fri, 2016-08-19 at 20:44 +0100, James Simmons wrote:

Hi again James.

> > I don't _need_ anything, but I think it'd be simpler to
> > have just 2 directories, one for lustre kernel stuff
> > and another for lustre uapi stuff.
> > 
> > That applies for LNet and libcfs #includes as well.
> > 
> > To me, ideally, there'd only be 2 #include directories
> > so that the only used #include styles could become:
> > 
> > #include 
> > and
> > #include 
> > 
> > and that would work regardless of lustre's layout
> > in staging or elsewhere.
> I didn't expect this to be requested at this time. I thought this would be 
> addressed just before we left staging.

Sooner is better to me, but that's up to you all.

> I had to ponder the impact of
> this change since this affects our userland utilities as well. Moving
> the staging/lustre/lustre/include/* to include/linux/lustre is pretty
> straight forward for the internal kernel headers.
> 
> The issues is that we still have entanglement issues with some of our uapi 
> headers with internals of the kernel leaking to userland.

Identifying the u_int_<size> and __u<size> types in the code
by userland/kernel uses could be done more easily after any
#include uapi/kernel separation is done.
> Would that be acceptable?

That's not for me to decide really.
It's not an immediate or even necessary want.
It's just a code reading convenience to me.


> This Wednsday we have a lustre community conference call were we discuss
> upstream issues. This will need to be discussed.  

Enjoy.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/7] staging: lustre: last missing patches for lustre 2.6 James Simmons <jsimmons@infradead.org> - 2016-08-19 20:10 +0200
  [PATCH 7/7] staging: lustre: update version to 2.5.99 James Simmons <jsimmons@infradead.org> - 2016-08-19 20:10 +0200
  [PATCH 2/7] staging: lustre: llite: move dir cache to MDC layer James Simmons <jsimmons@infradead.org> - 2016-08-19 20:10 +0200
  [PATCH 5/7] staging: lustre: obd: remove dead code James Simmons <jsimmons@infradead.org> - 2016-08-19 20:10 +0200
  [PATCH 3/7] staging: lustre: obd: remove unused lmv_readpages()/mdc_readpage() James Simmons <jsimmons@infradead.org> - 2016-08-19 20:10 +0200
  [PATCH 1/7] staging: lustre: lmv: implement lmv version of read_page James Simmons <jsimmons@infradead.org> - 2016-08-19 20:10 +0200
  [PATCH 4/7] staging: lustre: mdt: add OBD_CONNECT_DIR_STRIPE flag James Simmons <jsimmons@infradead.org> - 2016-08-19 20:10 +0200
  [PATCH 6/7] staging: lustre: obd: decruft md_enqueue() and md_intent_lock() James Simmons <jsimmons@infradead.org> - 2016-08-19 20:10 +0200
  Re: [PATCH 0/7] staging: lustre: last missing patches for lustre 2.6 Joe Perches <joe@perches.com> - 2016-08-19 20:40 +0200
    Re: [PATCH 0/7] staging: lustre: last missing patches for lustre  2.6 James Simmons <jsimmons@infradead.org> - 2016-08-19 21:50 +0200
      Re: [PATCH 0/7] staging: lustre: last missing patches for lustre 2.6 Joe Perches <joe@perches.com> - 2016-08-19 22:10 +0200
        Re: [PATCH 0/7] staging: lustre: last missing patches for lustre  2.6 James Simmons <jsimmons@infradead.org> - 2016-08-22 19:50 +0200
          Re: [PATCH 0/7] staging: lustre: last missing patches for lustre 2.6 Joe Perches <joe@perches.com> - 2016-08-22 20:00 +0200
            Re: [PATCH 0/7] staging: lustre: last missing patches for lustre 2.6 Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-08-22 22:40 +0200

csiph-web