Re: [PATCH] staging: lustre: llite: don't clean in_data again

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Oleg Drokin <oleg.drokin@intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] staging: lustre: llite: don't clean in_data again
Date	Sun, 21 Aug 2016 05:40:01 +0200
Message-ID	<s8rM5-3tf-1@gated-at.bofh.it> (permalink)
References	<s8qZH-2Xg-1@gated-at.bofh.it>
X-Original-To	Shawn Lin <shawn.lin@rock-chips.com>
X-Extloop1	1
X-Ironport-Av	E=Sophos;i="5.28,553,1464678000"; d="scan'208";a="158944679"
MIME-Version	1.0 (Apple Message framework v1283)
Content-Type	text/plain; charset=us-ascii
Content-Transfer-Encoding	8BIT
X-Mailer	Apple Mail (2.1283)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	28
Organization	linux.* mail to news gateway
X-Original-Cc	Andreas Dilger <andreas.dilger@intel.com>, James Simmons <jsimmons@infradead.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, <lustre-devel@lists.lustre.org>, <devel@driverdev.osuosl.org>, <linux-kernel@vger.kernel.org>
X-Original-Date	Sat, 20 Aug 2016 23:38:49 -0400
X-Original-Message-ID	<CA538835-AB7D-46CC-8C01-02CE2526D76F@intel.com>
X-Original-References	<1471747477-31654-1-git-send-email-shawn.lin@rock-chips.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1466912

Show key headers only | View raw

Acked-by: Oleg Drokin <oleg.drokin@intel.com>

On Aug 20, 2016, at 10:44 PM, Shawn Lin wrote:

> We have got a zero buffer for in_data as we use
> kzalloc here. So let's remove it anyway.
> 
> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
> ---
> 
> drivers/staging/lustre/lustre/llite/file.c | 1 -
> 1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/staging/lustre/lustre/llite/file.c b/drivers/staging/lustre/lustre/llite/file.c
> index 50938bd..ec6b7ce 100644
> --- a/drivers/staging/lustre/lustre/llite/file.c
> +++ b/drivers/staging/lustre/lustre/llite/file.c
> @@ -3251,7 +3251,6 @@ void *ll_iocontrol_register(llioc_callback_t cb, int count, unsigned int *cmd)
> 	if (!in_data)
> 		return NULL;
> 
> -	memset(in_data, 0, sizeof(*in_data));
> 	in_data->iocd_size = size;
> 	in_data->iocd_cb = cb;
> 	in_data->iocd_count = count;
> -- 
> 2.3.7
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] staging: lustre: llite: don't clean in_data again Shawn Lin <shawn.lin@rock-chips.com> - 2016-08-21 04:50 +0200
  Re: [PATCH] staging: lustre: llite: don't clean in_data again Oleg Drokin <oleg.drokin@intel.com> - 2016-08-21 05:40 +0200

csiph-web