Re: [PATCH] lib/Kconfig.debug: fix typo in select statement

From	Kees Cook <keescook@chromium.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] lib/Kconfig.debug: fix typo in select statement
Date	2016-08-21 05:30 +0200
Message-ID	<s8rCp-3p4-1@gated-at.bofh.it> (permalink)
References	<s8bxD-1Df-1@gated-at.bofh.it> <s8jbP-6v0-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sat, Aug 20, 2016 at 11:20 AM, Paul E. McKenney
<paulmck@linux.vnet.ibm.com> wrote:
> On Sat, Aug 20, 2016 at 12:16:10PM +0200, Valentin Rothberg wrote:
>> Commit 484f29c7430b3 ("bug: Provide toggle for BUG on data corruption")
>> added a Kconfig select statement on CONFIG_DEBUG_LIST, but the CONFIG_
>> prefix is only used in Make and C(PP) syntax.  Remove the CONFIG_ prefix
>> to correctly select the Kconfig option DEBUG_LIST.
>>
>> Signed-off-by: Valentin Rothberg <valentinrothberg@gmail.com>
>
> Well, color me blind!
>
> Good catch, queued for review and testing.
>
> Kees, Steve, Rik, any objections?

Argh, thank you. Yes, this is correct.

Acked-by: Kees Cook <keescook@chromium.org>

-Kees

>
>                                                         Thanx, Paul
>
>> ---
>> I detected the issue with scripts/checkkconfigsymbols.py
>>
>>  lib/Kconfig.debug | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
>> index 5dea4d0a5a07..c2bbaae13d04 100644
>> --- a/lib/Kconfig.debug
>> +++ b/lib/Kconfig.debug
>> @@ -2009,7 +2009,7 @@ config TEST_STATIC_KEYS
>>
>>  config BUG_ON_DATA_CORRUPTION
>>       bool "Trigger a BUG when data corruption is detected"
>> -     select CONFIG_DEBUG_LIST
>> +     select DEBUG_LIST
>>       help
>>         Select this option if the kernel should BUG when it encounters
>>         data corruption in kernel memory structures when they get checked
>> --
>> 2.9.3
>>
>



-- 
Kees Cook
Nexus Security

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] lib/Kconfig.debug: fix typo in select statement Valentin Rothberg <valentinrothberg@gmail.com> - 2016-08-20 12:20 +0200
  Re: [PATCH] lib/Kconfig.debug: fix typo in select statement "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2016-08-20 20:30 +0200
    Re: [PATCH] lib/Kconfig.debug: fix typo in select statement Kees Cook <keescook@chromium.org> - 2016-08-21 05:30 +0200

csiph-web