Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1465526

[PATCH] mwifiex: propagate error if IRQ request fails in mwifiex_sdio_of()

From Javier Martinez Canillas <javier@osg.samsung.com>
Newsgroups linux.kernel
Subject [PATCH] mwifiex: propagate error if IRQ request fails in mwifiex_sdio_of()
Date 2016-08-18 16:30 +0200
Message-ID <s7wuv-WK-63@gated-at.bofh.it> (permalink)
Organization linux.* mail to news gateway

Show all headers | View raw


If request_irq() fails in mwifiex_sdio_probe_of(), only an error message
is printed but the actual error is not propagated to the caller function.

Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---

 drivers/net/wireless/marvell/mwifiex/sdio.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/wireless/marvell/mwifiex/sdio.c b/drivers/net/wireless/marvell/mwifiex/sdio.c
index d3e1561ca075..00727936ad6e 100644
--- a/drivers/net/wireless/marvell/mwifiex/sdio.c
+++ b/drivers/net/wireless/marvell/mwifiex/sdio.c
@@ -125,6 +125,7 @@ static int mwifiex_sdio_probe_of(struct device *dev, struct sdio_mmc_card *card)
 				dev_err(dev,
 					"Failed to request irq_wifi %d (%d)\n",
 					cfg->irq_wifi, ret);
+				return ret;
 			}
 			disable_irq(cfg->irq_wifi);
 		}
-- 
2.5.5

Back to linux.kernel | Previous | NextNext in thread | Find similar | Unroll thread


Thread

[PATCH] mwifiex: propagate error if IRQ request fails in mwifiex_sdio_of() Javier Martinez Canillas <javier@osg.samsung.com> - 2016-08-18 16:30 +0200
  Re: [PATCH] mwifiex: propagate error if IRQ request fails in  mwifiex_sdio_of() Arend van Spriel <arend.vanspriel@broadcom.com> - 2016-08-19 03:00 +0200
    Re: [PATCH] mwifiex: propagate error if IRQ request fails in  mwifiex_sdio_of() Javier Martinez Canillas <javier@osg.samsung.com> - 2016-08-19 04:30 +0200
  Re: [PATCH] mwifiex: propagate error if IRQ request fails in  mwifiex_sdio_of() Arend van Spriel <arend.vanspriel@broadcom.com> - 2016-08-19 03:10 +0200
    Re: [PATCH] mwifiex: propagate error if IRQ request fails in  mwifiex_sdio_of() Javier Martinez Canillas <javier@osg.samsung.com> - 2016-08-19 03:40 +0200

csiph-web