Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1466533
| From | Jonathan Corbet <corbet@lwn.net> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v9 1/2] Documentation: kdump: remind user of nr_cpus |
| Date | 2016-08-19 18:00 +0200 |
| Message-ID | <s7Un8-7vi-49@gated-at.bofh.it> (permalink) |
| References | <s7m25-2f3-3@gated-at.bofh.it> <s7m25-2f3-1@gated-at.bofh.it> <s7Gk9-6XF-1@gated-at.bofh.it> <s7Gkb-6XF-73@gated-at.bofh.it> |
| Organization | LWN.net |
On Fri, 19 Aug 2016 08:33:21 +0800 "Zhou, Wenjian/周文剑" <zhouwj-fnst@cn.fujitsu.com> wrote: > I was also confused by maxcpus and nr_cpus before writing this patch. > I think it is a good choice to describe it in kernel-parameters.txt. > > Then, only two things need to be done I think. > One is move the above description to maxcpus= in kernel-parameters.txt. > And the other is replace maxcpus with maxcpus/nr_cpus in kdump.txt. > > How do you think? That is not quite what I had in mind, sorry. What I would really like to see in kernel-parameters.txt is an explanation of how those two parameters differ - what do they do differently and how should a user choose one over the other? What we have now offers no guidance in that matter. I suspect that may be a bit more than you had signed up to do. As an intermediate step, how about this: rather than tacking on those lines in kdump.txt, rewrite that paragraph to simply say what the reader should use. If nr_cpus is good for everybody, just say that, but your previous patch suggests that the situation isn't quite that simple? Thanks, jon
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v9 1/2] Documentation: kdump: remind user of nr_cpus Zhou Wenjian <zhouwj-fnst@cn.fujitsu.com> - 2016-08-18 05:20 +0200
Re: [PATCH v9 1/2] Documentation: kdump: remind user of nr_cpus Jonathan Corbet <corbet@lwn.net> - 2016-08-19 03:00 +0200
Re: [PATCH v9 1/2] Documentation: kdump: remind user of nr_cpus "Zhou, Wenjian/周文剑" <zhouwj-fnst@cn.fujitsu.com> - 2016-08-19 03:00 +0200
Re: [PATCH v9 1/2] Documentation: kdump: remind user of nr_cpus Jonathan Corbet <corbet@lwn.net> - 2016-08-19 18:00 +0200
Re: [PATCH v9 1/2] Documentation: kdump: remind user of nr_cpus "Zhou, Wenjian/周文剑" <zhouwj-fnst@cn.fujitsu.com> - 2016-08-22 03:20 +0200
Re: [PATCH v9 1/2] Documentation: kdump: remind user of nr_cpus Baoquan He <bhe@redhat.com> - 2016-08-24 07:10 +0200
csiph-web