Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1465670

Re: [PATCH v9 1/2] Documentation: kdump: remind user of nr_cpus

Show all headers | View raw

On Thu, 18 Aug 2016 11:11:46 +0800
Zhou Wenjian <zhouwj-fnst@cn.fujitsu.com> wrote:

Thank you for working to improve the documentation!

>  * We generally don' have to bring up a SMP kernel just to capture the
>    dump. Hence generally it is useful either to build a UP dump-capture
>    kernel or specify maxcpus=1 option while loading dump-capture kernel.
> +  Note, though maxcpus always works, you should replace it by nr_cpus to
> +  save memory if supported by the current ARCH, such as x86.

So, IMHO, this seems like the wrong place for this.  I've just spent a bit
of time staring at kernel-parameters.txt, and there is no way for a
clueless user like me to know what the difference is between maxcpus= and
nr_cpus= would be.  A far better patch would be to update the
documentation there to make that clear.  Any chance you would be willing
to do that?

Then, rather than tacking an "ignore what you just read" note into
kdump.txt, it could maybe be rewritten to simply say what users should do?

Thanks,

jon

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v9 1/2] Documentation: kdump: remind user of nr_cpus Zhou Wenjian <zhouwj-fnst@cn.fujitsu.com> - 2016-08-18 05:20 +0200
  Re: [PATCH v9 1/2] Documentation: kdump: remind user of nr_cpus Jonathan Corbet <corbet@lwn.net> - 2016-08-19 03:00 +0200
    Re: [PATCH v9 1/2] Documentation: kdump: remind user of nr_cpus "Zhou, Wenjian/周文剑"          <zhouwj-fnst@cn.fujitsu.com> - 2016-08-19 03:00 +0200
      Re: [PATCH v9 1/2] Documentation: kdump: remind user of nr_cpus Jonathan Corbet <corbet@lwn.net> - 2016-08-19 18:00 +0200
        Re: [PATCH v9 1/2] Documentation: kdump: remind user of nr_cpus "Zhou, Wenjian/周文剑"          <zhouwj-fnst@cn.fujitsu.com> - 2016-08-22 03:20 +0200
          Re: [PATCH v9 1/2] Documentation: kdump: remind user of nr_cpus Baoquan He <bhe@redhat.com> - 2016-08-24 07:10 +0200

csiph-web