Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1464363

Re: [PATCH] Map in physical addresses in efi_map_region_fixed

From Dave Young <dyoung@redhat.com>
Newsgroups linux.kernel
Subject Re: [PATCH] Map in physical addresses in efi_map_region_fixed
Date 2016-08-17 09:10 +0200
Message-ID <s7398-6a6-5@gated-at.bofh.it> (permalink)
References <s3gRp-2h2-9@gated-at.bofh.it> <s6pv3-5Eh-11@gated-at.bofh.it> <s6rGy-7aD-33@gated-at.bofh.it> <s6v7r-II-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


> > Why do you guys need the physical mapping all of a sudden?
> 
> It's not that we need it all of the sudden, necessarily, it's just that
> we've had to make other changes to make things work with the new,
> (almost) completely isolated, EFI page tables.  We ended up choosing the
> lesser of two evils, and have decided to temporarily rely on the
> physical address of our runtime code, instead of continuing to rely on
> EFI_OLD_MEMMAP.

In efi_map_region, there is already mapped md->phys_addr for broken
firmware. SGI still need EFI_OLD_MEMMAP? I means in 1st kernel instead
of kexec kernel.

void __init efi_map_region(efi_memory_desc_t *md)
{
        unsigned long size = md->num_pages << PAGE_SHIFT;
        u64 pa = md->phys_addr;

        if (efi_enabled(EFI_OLD_MEMMAP))
                return old_map_region(md);

        /*
         * Make sure the 1:1 mappings are present as a catch-all for
         * b0rked
         * firmware which doesn't update all internal pointers after
         * switching
         * to virtual mode and would otherwise crap on us.
         */
        __map_region(md, md->phys_addr);

[snip]

Thanks
Dave

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

Re: [PATCH] Map in physical addresses in efi_map_region_fixed Matt Fleming <matt@codeblueprint.co.uk> - 2016-08-15 14:50 +0200
  Re: [PATCH] Map in physical addresses in efi_map_region_fixed Borislav Petkov <bp@alien8.de> - 2016-08-15 17:10 +0200
    Re: [PATCH] Map in physical addresses in efi_map_region_fixed Alex Thorlton <athorlton@sgi.com> - 2016-08-15 20:50 +0200
      Re: [PATCH] Map in physical addresses in efi_map_region_fixed "H. Peter Anvin" <hpa@zytor.com> - 2016-08-16 00:00 +0200
        Re: [PATCH] Map in physical addresses in efi_map_region_fixed Borislav Petkov <bp@alien8.de> - 2016-08-16 07:40 +0200
      Re: [PATCH] Map in physical addresses in efi_map_region_fixed Borislav Petkov <bp@alien8.de> - 2016-08-16 08:00 +0200
        Re: [PATCH] Map in physical addresses in efi_map_region_fixed Alex Thorlton <athorlton@sgi.com> - 2016-08-16 17:30 +0200
      Re: [PATCH] Map in physical addresses in efi_map_region_fixed Dave Young <dyoung@redhat.com> - 2016-08-17 09:10 +0200
        Re: [PATCH] Map in physical addresses in efi_map_region_fixed Alex Thorlton <athorlton@sgi.com> - 2016-08-17 18:10 +0200
          Re: [PATCH] Map in physical addresses in efi_map_region_fixed Dave Young <dyoung@redhat.com> - 2016-08-18 08:20 +0200
    Re: [PATCH] Map in physical addresses in efi_map_region_fixed Matt Fleming <matt@codeblueprint.co.uk> - 2016-08-16 14:40 +0200
      Re: [PATCH] Map in physical addresses in efi_map_region_fixed Borislav Petkov <bp@alien8.de> - 2016-08-16 15:40 +0200

csiph-web