Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1462868

Re: [PATCH] Map in physical addresses in efi_map_region_fixed

Show all headers | View raw

On Mon, Aug 15, 2016 at 01:42:58PM +0100, Matt Fleming wrote:
> (Cc'ing Boris and Dave)
> 
> On Fri, 05 Aug, at 06:59:35PM, Alex Thorlton wrote:
> > This is a simple change to add in the physical mappings as well as the
> > virtual mappings in efi_map_region_fixed.  The motivation here is to
> > get access to EFI runtime code that is only available via the 1:1
> > mappings on a kexec'd kernel.

So I don't understand: the whole jumping through hoops so that we have
stable virtual mappings just so that the kexec-ed kernel can call EFI
runtime, is now useless?!

What if the physical address is occupied by the kexec kernel?

Why do you guys need the physical mapping all of a sudden?

Your patch is basically rendering all the effort moot and we could've
saved ourselves all that trouble of doing all that virtual address
mapping and done the 1:1 thing.

Which really is probably simpler since we have an EFI-specific page
table and running EFI in the kexec-ed kernel would mean basically
recreating it.

What am I missing?

commit d2f7cbe7b26a74dbbbf8f325b2a6fd01bc34032c
Author: Borislav Petkov <bp@suse.de>
Date:   Thu Oct 31 17:25:08 2013 +0100

    x86/efi: Runtime services virtual mapping
    
    We map the EFI regions needed for runtime services non-contiguously,
    with preserved alignment on virtual addresses starting from -4G down
    for a total max space of 64G. This way, we provide for stable runtime
    services addresses across kernels so that a kexec'd kernel can still use
    them.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] Map in physical addresses in efi_map_region_fixed Matt Fleming <matt@codeblueprint.co.uk> - 2016-08-15 14:50 +0200
  Re: [PATCH] Map in physical addresses in efi_map_region_fixed Borislav Petkov <bp@alien8.de> - 2016-08-15 17:10 +0200
    Re: [PATCH] Map in physical addresses in efi_map_region_fixed Alex Thorlton <athorlton@sgi.com> - 2016-08-15 20:50 +0200
      Re: [PATCH] Map in physical addresses in efi_map_region_fixed "H. Peter Anvin" <hpa@zytor.com> - 2016-08-16 00:00 +0200
        Re: [PATCH] Map in physical addresses in efi_map_region_fixed Borislav Petkov <bp@alien8.de> - 2016-08-16 07:40 +0200
      Re: [PATCH] Map in physical addresses in efi_map_region_fixed Borislav Petkov <bp@alien8.de> - 2016-08-16 08:00 +0200
        Re: [PATCH] Map in physical addresses in efi_map_region_fixed Alex Thorlton <athorlton@sgi.com> - 2016-08-16 17:30 +0200
      Re: [PATCH] Map in physical addresses in efi_map_region_fixed Dave Young <dyoung@redhat.com> - 2016-08-17 09:10 +0200
        Re: [PATCH] Map in physical addresses in efi_map_region_fixed Alex Thorlton <athorlton@sgi.com> - 2016-08-17 18:10 +0200
          Re: [PATCH] Map in physical addresses in efi_map_region_fixed Dave Young <dyoung@redhat.com> - 2016-08-18 08:20 +0200
    Re: [PATCH] Map in physical addresses in efi_map_region_fixed Matt Fleming <matt@codeblueprint.co.uk> - 2016-08-16 14:40 +0200
      Re: [PATCH] Map in physical addresses in efi_map_region_fixed Borislav Petkov <bp@alien8.de> - 2016-08-16 15:40 +0200

csiph-web