Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1463247

Re: [PATCH 0/8] Remove deprecated workqueue interface users

Show all headers | View raw

On Sat, Aug 13, 2016 at 09:41:21PM +0530, Bhaktipriya Shridhar wrote:
> This patch set removes the instances of deprecated
> create_singlethread_workqueues in drivers/power by making the appropriate
> conversions.
> 
> Bhaktipriya Shridhar (8):
>   power: abx500_chargalg: Remove deprecated create_singlethread_workqueue
>   power: ab8500_btemp: Remove deprecated create_singlethread_workqueue
>   power: pm2301_charger: Remove deprecated create_singlethread_workqueue
>   power: intel_mid_battery: Remove deprecated create_singlethread_workqueue
>   power: ab8500_charger: Remove deprecated create_singlethread_workqueue
>   power: ipaq_micro_battery: Remove deprecated create_singlethread_workqueue
>   power: ab8500_fg: Remove deprecated create_singlethread_workqueue
>   power: ds2760_battery: Remove deprecated create_singlethread_workqueue

Patches look good to me.  I'm a bit curious about WQ_MEM_RECLAIM part
tho.  I suppose the reasoning is that as the hardware in question is
involved in battery management which may be time critical,
WQ_MEM_RECLAIM is added to ensure (timely) forward progress under
memory pressure, right?  It'd be great if someone who's more familiar
with these hardware can confirm whether this is actually necessary.

Oh, it'd also be nice to put the target subsystem in the subject of
the patchset - e.g. "[PATCH 0/8] power: Remove..."

Thanks.

-- 
tejun

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/8] Remove deprecated workqueue interface users Bhaktipriya Shridhar <bhaktipriya96@gmail.com> - 2016-08-13 18:20 +0200
  [PATCH 1/8] power: abx500_chargalg: Remove deprecated  create_singlethread_workqueue Bhaktipriya Shridhar <bhaktipriya96@gmail.com> - 2016-08-13 18:20 +0200
  Re: [PATCH 0/8] Remove deprecated workqueue interface users Tejun Heo <tj@kernel.org> - 2016-08-16 01:00 +0200
    Re: [PATCH 0/8] Remove deprecated workqueue interface users Sebastian Reichel <sre@kernel.org> - 2016-08-16 02:30 +0200
      Re: [PATCH 0/8] Remove deprecated workqueue interface users Tejun Heo <tj@kernel.org> - 2016-08-16 17:00 +0200
  Re: [PATCH 0/8] Remove deprecated workqueue interface users Sebastian Reichel <sre@kernel.org> - 2016-08-16 01:00 +0200

csiph-web