Re: [PATCH] drm: tilcdc: Fix check for remote port parent

Path	csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Jyri Sarha <jsarha@ti.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] drm: tilcdc: Fix check for remote port parent
Date	Mon, 15 Aug 2016 10:40:01 +0200
Message-ID	<s6lB7-3do-19@gated-at.bofh.it> (permalink)
References	<s6lhL-36L-1@gated-at.bofh.it>
User-Agent	Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0
MIME-Version	1.0
Content-Type	text/plain; charset="windows-1252"
Content-Transfer-Encoding	8bit
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	41
Organization	linux.* mail to news gateway
X-Original-Cc	David Airlie <airlied@linux.ie>, <dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>
X-Original-Date	Mon, 15 Aug 2016 11:32:10 +0300
X-Original-Message-ID	<be62825d-7e56-9243-f3f2-4ecda4ffba90@ti.com>
X-Original-References	<1471248988-13322-1-git-send-email-t.remmet@phytec.de>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1462634

Show key headers only | View raw

On 08/15/16 11:16, Teresa Remmet wrote:
> In function tilcdc_get_external_components the check for
> the remote port parent is not correct. We need a '||' instead of
> an '&&'.
> 
> Signed-off-by: Teresa Remmet <t.remmet@phytec.de>
> ---
> There has been send out a different version of this patch about a year ago.
> But there was no feedback at all. Please apply one of the solutions.
> 
> https://patchwork.kernel.org/patch/6596441/
> 

Oh, I wonder how I lost track of that first fix. I must have forgotten
it with some of those rejected BBB audio implementation attempts.

Not really sure if my earlier rewrite is actually any better that this.
I'll pick this one up for my next pull request.

Thanks!
Jyri

> Teresa
> 
>  drivers/gpu/drm/tilcdc/tilcdc_external.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/tilcdc/tilcdc_external.c b/drivers/gpu/drm/tilcdc/tilcdc_external.c
> index 03acb4f..ceba712 100644
> --- a/drivers/gpu/drm/tilcdc/tilcdc_external.c
> +++ b/drivers/gpu/drm/tilcdc/tilcdc_external.c
> @@ -145,7 +145,7 @@ int tilcdc_get_external_components(struct device *dev,
>  		struct device_node *node;
>  
>  		node = of_graph_get_remote_port_parent(ep);
> -		if (!node && !of_device_is_available(node)) {
> +		if (!node || !of_device_is_available(node)) {
>  			of_node_put(node);
>  			continue;
>  		}
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] drm: tilcdc: Fix check for remote port parent Teresa Remmet <t.remmet@phytec.de> - 2016-08-15 10:20 +0200
  Re: [PATCH] drm: tilcdc: Fix check for remote port parent Jyri Sarha <jsarha@ti.com> - 2016-08-15 10:40 +0200

csiph-web