Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1462625

[PATCH] drm: tilcdc: Fix check for remote port parent

Show all headers | View raw

In function tilcdc_get_external_components the check for
the remote port parent is not correct. We need a '||' instead of
an '&&'.

Signed-off-by: Teresa Remmet <t.remmet@phytec.de>
---
There has been send out a different version of this patch about a year ago.
But there was no feedback at all. Please apply one of the solutions.

https://patchwork.kernel.org/patch/6596441/

Teresa

 drivers/gpu/drm/tilcdc/tilcdc_external.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/tilcdc/tilcdc_external.c b/drivers/gpu/drm/tilcdc/tilcdc_external.c
index 03acb4f..ceba712 100644
--- a/drivers/gpu/drm/tilcdc/tilcdc_external.c
+++ b/drivers/gpu/drm/tilcdc/tilcdc_external.c
@@ -145,7 +145,7 @@ int tilcdc_get_external_components(struct device *dev,
 		struct device_node *node;
 
 		node = of_graph_get_remote_port_parent(ep);
-		if (!node && !of_device_is_available(node)) {
+		if (!node || !of_device_is_available(node)) {
 			of_node_put(node);
 			continue;
 		}
-- 
1.9.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] drm: tilcdc: Fix check for remote port parent Teresa Remmet <t.remmet@phytec.de> - 2016-08-15 10:20 +0200
  Re: [PATCH] drm: tilcdc: Fix check for remote port parent Jyri Sarha <jsarha@ti.com> - 2016-08-15 10:40 +0200

csiph-web