Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1462517

Re: [RFC 5/7] Bluetooth: hci_nokia: Introduce new driver

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi Paul,

On Sun, Aug 14, 2016 at 07:54:28PM -0400, Paul Gortmaker wrote:
> On Fri, Aug 12, 2016 at 11:14 PM, Sebastian Reichel <sre@kernel.org> wrote:
> > This driver adds support for Nokia H4+ procotol used
> > for example by Nokia's internet tablets (N770 - N950).
> >
> > [...]
> >
> > +config BT_HCIUART_NOKIA
> > +       bool "UART Nokia H4+ protocol support"
> 
> If the option is a bool, then you don't need module.h or any MODULE
> macros, nor do you need any __exit or unregister related code.
> 
> Alternatively, if there is a use case for it to be modular, then maybe you
> want to change the above to a tristate.

Actually it is bool and modular: It becomes part of the module
configured by the tristate CONFIG_BT_HCIUART option.

-- Sebastian

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RFC 0/7] Nokia N9xx bluetooth driver Sebastian Reichel <sre@kernel.org> - 2016-08-13 05:20 +0200
  [RFC 1/7] tty: serial: omap: add UPF_BOOT_AUTOCONF flag for DT init Sebastian Reichel <sre@kernel.org> - 2016-08-13 05:20 +0200
    Re: [RFC 1/7] tty: serial: omap: add UPF_BOOT_AUTOCONF flag for DT  init Pavel Machek <pavel@ucw.cz> - 2016-08-14 11:00 +0200
      Re: [RFC 1/7] tty: serial: omap: add UPF_BOOT_AUTOCONF flag for DT  init Sebastian Reichel <sre@kernel.org> - 2016-08-16 10:20 +0200
  [RFC 5/7] Bluetooth: hci_nokia: Introduce new driver Sebastian Reichel <sre@kernel.org> - 2016-08-13 05:20 +0200
    Re: [RFC 5/7] Bluetooth: hci_nokia: Introduce new driver Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-08-15 02:00 +0200
      Re: [RFC 5/7] Bluetooth: hci_nokia: Introduce new driver Sebastian Reichel <sre@kernel.org> - 2016-08-15 03:20 +0200
    Re: [RFC 5/7] Bluetooth: hci_nokia: Introduce new driver Marcel Holtmann <marcel@holtmann.org> - 2016-08-16 09:10 +0200
      Re: [RFC 5/7] Bluetooth: hci_nokia: Introduce new driver Pali Rohár <pali.rohar@gmail.com> - 2016-08-16 10:00 +0200
        Re: [RFC 5/7] Bluetooth: hci_nokia: Introduce new driver Sebastian Reichel <sre@kernel.org> - 2016-08-16 11:30 +0200
      Re: [RFC 5/7] Bluetooth: hci_nokia: Introduce new driver Sebastian Reichel <sre@kernel.org> - 2016-08-16 11:20 +0200
        Re: [RFC 5/7] Bluetooth: hci_nokia: Introduce new driver Marcel Holtmann <marcel@holtmann.org> - 2016-08-16 12:30 +0200
        Re: [RFC 5/7] Bluetooth: hci_nokia: Introduce new driver Marcel Holtmann <marcel@holtmann.org> - 2016-08-16 12:30 +0200
          Re: [RFC 5/7] Bluetooth: hci_nokia: Introduce new driver Pavel Machek <pavel@ucw.cz> - 2016-08-16 22:10 +0200
    Re: [RFC 5/7] Bluetooth: hci_nokia: Introduce new driver Marcel Holtmann <marcel@holtmann.org> - 2016-08-16 10:20 +0200
      Re: [RFC 5/7] Bluetooth: hci_nokia: Introduce new driver Sebastian Reichel <sre@kernel.org> - 2016-08-16 11:40 +0200
  Re: [RFC 0/7] Nokia N9xx bluetooth driver Marcel Holtmann <marcel@holtmann.org> - 2016-08-16 09:20 +0200
    Re: [RFC 0/7] Nokia N9xx bluetooth driver Rob Herring <robh+dt@kernel.org> - 2016-08-16 22:30 +0200

csiph-web