Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1463605

Re: [RFC 5/7] Bluetooth: hci_nokia: Introduce new driver

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi Marcel,

On Tue, Aug 16, 2016 at 10:10:07AM +0200, Marcel Holtmann wrote:
> > diff --git a/drivers/bluetooth/hci_uart.h b/drivers/bluetooth/hci_uart.h
> > index a7d67aec3632..314b243df996 100644
> > --- a/drivers/bluetooth/hci_uart.h
> > +++ b/drivers/bluetooth/hci_uart.h
> > @@ -35,7 +35,7 @@
> > #define HCIUARTGETFLAGS		_IOR('U', 204, int)
> > 
> > /* UART protocols */
> > -#define HCI_UART_MAX_PROTO	10
> > +#define HCI_UART_MAX_PROTO	11
> > 
> > #define HCI_UART_H4	0
> > #define HCI_UART_BCSP	1
> > @@ -47,6 +47,7 @@
> > #define HCI_UART_BCM	7
> > #define HCI_UART_QCA	8
> > #define HCI_UART_AG6XX	9
> > +#define HCI_UART_NOKIA	10
> 
> since it seems the driver is getting closer to be ready,
> lets merge this extra protocol identifier as a separate patch.

depends on the definition of "the driver". It requires
the gpio information from DT, so it depends on the new
serial bus. I still have to implement that and it has
the potential to trigger a bit of discussion :)

Anyways I will split this out into its own patch later. 

> Then we can adapt btattach as well for it.

It's enough to set ldisc=N_HCI and proto=HCI_UART_NOKIA.
Everything else is done by the protocol driver. I still
think it should be done from the kernel and will try to
come up with something in the serial bus.

-- Sebastian

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RFC 0/7] Nokia N9xx bluetooth driver Sebastian Reichel <sre@kernel.org> - 2016-08-13 05:20 +0200
  [RFC 1/7] tty: serial: omap: add UPF_BOOT_AUTOCONF flag for DT init Sebastian Reichel <sre@kernel.org> - 2016-08-13 05:20 +0200
    Re: [RFC 1/7] tty: serial: omap: add UPF_BOOT_AUTOCONF flag for DT  init Pavel Machek <pavel@ucw.cz> - 2016-08-14 11:00 +0200
      Re: [RFC 1/7] tty: serial: omap: add UPF_BOOT_AUTOCONF flag for DT  init Sebastian Reichel <sre@kernel.org> - 2016-08-16 10:20 +0200
  [RFC 5/7] Bluetooth: hci_nokia: Introduce new driver Sebastian Reichel <sre@kernel.org> - 2016-08-13 05:20 +0200
    Re: [RFC 5/7] Bluetooth: hci_nokia: Introduce new driver Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-08-15 02:00 +0200
      Re: [RFC 5/7] Bluetooth: hci_nokia: Introduce new driver Sebastian Reichel <sre@kernel.org> - 2016-08-15 03:20 +0200
    Re: [RFC 5/7] Bluetooth: hci_nokia: Introduce new driver Marcel Holtmann <marcel@holtmann.org> - 2016-08-16 09:10 +0200
      Re: [RFC 5/7] Bluetooth: hci_nokia: Introduce new driver Pali Rohár <pali.rohar@gmail.com> - 2016-08-16 10:00 +0200
        Re: [RFC 5/7] Bluetooth: hci_nokia: Introduce new driver Sebastian Reichel <sre@kernel.org> - 2016-08-16 11:30 +0200
      Re: [RFC 5/7] Bluetooth: hci_nokia: Introduce new driver Sebastian Reichel <sre@kernel.org> - 2016-08-16 11:20 +0200
        Re: [RFC 5/7] Bluetooth: hci_nokia: Introduce new driver Marcel Holtmann <marcel@holtmann.org> - 2016-08-16 12:30 +0200
        Re: [RFC 5/7] Bluetooth: hci_nokia: Introduce new driver Marcel Holtmann <marcel@holtmann.org> - 2016-08-16 12:30 +0200
          Re: [RFC 5/7] Bluetooth: hci_nokia: Introduce new driver Pavel Machek <pavel@ucw.cz> - 2016-08-16 22:10 +0200
    Re: [RFC 5/7] Bluetooth: hci_nokia: Introduce new driver Marcel Holtmann <marcel@holtmann.org> - 2016-08-16 10:20 +0200
      Re: [RFC 5/7] Bluetooth: hci_nokia: Introduce new driver Sebastian Reichel <sre@kernel.org> - 2016-08-16 11:40 +0200
  Re: [RFC 0/7] Nokia N9xx bluetooth driver Marcel Holtmann <marcel@holtmann.org> - 2016-08-16 09:20 +0200
    Re: [RFC 0/7] Nokia N9xx bluetooth driver Rob Herring <robh+dt@kernel.org> - 2016-08-16 22:30 +0200

csiph-web