Re: [PATCH 1/3] mm: fix set pageblock migratetype in deferred struct page init

Path	csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Xishi Qiu <qiuxishi@huawei.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/3] mm: fix set pageblock migratetype in deferred struct page init
Date	Tue, 16 Aug 2016 11:00:01 +0200
Message-ID	<s6Io1-R5-13@gated-at.bofh.it> (permalink)
References	<s2p0B-8g0-7@gated-at.bofh.it> <s2p0B-8g0-5@gated-at.bofh.it> <s6Iem-Nx-13@gated-at.bofh.it>
X-Original-To	Michal Hocko <mhocko@kernel.org>
User-Agent	Mozilla/5.0 (Windows NT 6.1; rv:12.0) Gecko/20120428 Thunderbird/12.0.1
MIME-Version	1.0
Content-Type	text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding	7bit
X-Originating-IP	[10.177.25.179]
X-Cfilter-Loop	Reflected
X-Mirapoint-Virus-Rapid-Raw	score=unknown(0), refid=str=0001.0A020205.57B2D560.00DB,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-05-26 15:14:31, dmn=2013-03-21 17:37:32
X-Mirapoint-Loop-ID	70e9d26c47df41f341321da50cdfff83
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	19
Organization	linux.* mail to news gateway
X-Original-Cc	Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>, Vlastimil Babka <vbabka@suse.cz>, Mel Gorman <mgorman@techsingularity.net>, Andrew Morton <akpm@linux-foundation.org>, David Rientjes <rientjes@google.com>, Joonsoo Kim <iamjoonsoo.kim@lge.com>, Taku Izumi <izumi.taku@jp.fujitsu.com>, "'Kirill A . Shutemov'" <kirill.shutemov@linux.intel.com>, Kamezawa Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>, Linux MM <linux-mm@kvack.org>, LKML <linux-kernel@vger.kernel.org>
X-Original-Date	Tue, 16 Aug 2016 16:56:54 +0800
X-Original-Message-ID	<57B2D556.5030201@huawei.com>
X-Original-References	<57A325CA.9050707@huawei.com> <57A3260F.4050709@huawei.com> <20160816084132.GA17417@dhcp22.suse.cz>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1463557

Show key headers only | View raw

On 2016/8/16 16:41, Michal Hocko wrote:

> On Thu 04-08-16 19:25:03, Xishi Qiu wrote:
>> MAX_ORDER_NR_PAGES is usually 4M, and a pageblock is usually 2M, so we only
>> set one pageblock's migratetype in deferred_free_range() if pfn is aligned
>> to MAX_ORDER_NR_PAGES.
> 
> Do I read the changelog correctly and the bug causes leaking unmovable
> allocations into movable zones?

Hi Michal,

This bug will cause uninitialized migratetype, you can see from
"cat /proc/pagetypeinfo", almost half blocks are Unmovable.

Also this bug missed to free the last block pages, it cause memory leaking.

Thanks,
Xishi Qiu

Thread

Re: [PATCH 1/3] mm: fix set pageblock migratetype in deferred struct  page init Michal Hocko <mhocko@kernel.org> - 2016-08-16 10:50 +0200
  Re: [PATCH 1/3] mm: fix set pageblock migratetype in deferred struct  page init Xishi Qiu <qiuxishi@huawei.com> - 2016-08-16 11:00 +0200
    Re: [PATCH 1/3] mm: fix set pageblock migratetype in deferred struct  page init Michal Hocko <mhocko@kernel.org> - 2016-08-16 11:30 +0200
      [PATCH v2] mm: fix set pageblock migratetype in deferred struct page  init Xishi Qiu <qiuxishi@huawei.com> - 2016-08-16 12:10 +0200
      Re: [PATCH 1/3] mm: fix set pageblock migratetype in deferred struct  page init Vlastimil Babka <vbabka@suse.cz> - 2016-08-16 12:20 +0200
        Re: [PATCH 1/3] mm: fix set pageblock migratetype in deferred struct  page init Xishi Qiu <qiuxishi@huawei.com> - 2016-08-16 12:30 +0200
        Re: [PATCH 1/3] mm: fix set pageblock migratetype in deferred struct  page init Michal Hocko <mhocko@kernel.org> - 2016-08-16 13:20 +0200

csiph-web