Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1463557

Re: [PATCH 1/3] mm: fix set pageblock migratetype in deferred struct page init

Show all headers | View raw

On 2016/8/16 16:41, Michal Hocko wrote:

> On Thu 04-08-16 19:25:03, Xishi Qiu wrote:
>> MAX_ORDER_NR_PAGES is usually 4M, and a pageblock is usually 2M, so we only
>> set one pageblock's migratetype in deferred_free_range() if pfn is aligned
>> to MAX_ORDER_NR_PAGES.
> 
> Do I read the changelog correctly and the bug causes leaking unmovable
> allocations into movable zones?

Hi Michal,

This bug will cause uninitialized migratetype, you can see from
"cat /proc/pagetypeinfo", almost half blocks are Unmovable.

Also this bug missed to free the last block pages, it cause memory leaking.

Thanks,
Xishi Qiu

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 1/3] mm: fix set pageblock migratetype in deferred struct  page init Michal Hocko <mhocko@kernel.org> - 2016-08-16 10:50 +0200
  Re: [PATCH 1/3] mm: fix set pageblock migratetype in deferred struct  page init Xishi Qiu <qiuxishi@huawei.com> - 2016-08-16 11:00 +0200
    Re: [PATCH 1/3] mm: fix set pageblock migratetype in deferred struct  page init Michal Hocko <mhocko@kernel.org> - 2016-08-16 11:30 +0200
      [PATCH v2] mm: fix set pageblock migratetype in deferred struct page  init Xishi Qiu <qiuxishi@huawei.com> - 2016-08-16 12:10 +0200
      Re: [PATCH 1/3] mm: fix set pageblock migratetype in deferred struct  page init Vlastimil Babka <vbabka@suse.cz> - 2016-08-16 12:20 +0200
        Re: [PATCH 1/3] mm: fix set pageblock migratetype in deferred struct  page init Xishi Qiu <qiuxishi@huawei.com> - 2016-08-16 12:30 +0200
        Re: [PATCH 1/3] mm: fix set pageblock migratetype in deferred struct  page init Michal Hocko <mhocko@kernel.org> - 2016-08-16 13:20 +0200

csiph-web