Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1462141

Re: [PATCH 0/2] be2iscsi: Logging neatening

Show all headers | View raw

On 08/13/16 13:42, Joe Perches wrote:
> Joe Perches (2):
>   be2iscsi: Coalesce split strings and formats
>   be2iscsi: Use a standard logging style

Hello Joe,

As one can see in be_main.h the "level" argument of macro beiscsi_log() 
is ignored for log levels KERN_EMERG, KERN_ALERT, KERN_CRIT and
KERN_ERR. So for these log levels beiscsi_log() is a synonym of 
shost_printk(). Have you considered to replace beiscsi_log() with 
shost_printk() for these log levels and additionally to change 
beiscsi_log() for the other log levels into pr_debug()? pr_debug() 
statements namely already can be enabled and disabled at runtime. If the 
BEISCSI_LOG_* log category would be embedded in the log text that would 
allow to eliminate the phba->attr_log_enable structure member. 
Additionally, pr_debug() has a facility for displaying the source file 
name and the line number. That would allow to leave out __LINE__ from 
be2iscsi log statements. I don't think it is useful to have that line 
number in non-debug be2iscsi log statements.

Thanks,

Bart.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 2/2] be2iscsi: Fix some error messages Christophe JAILLET <christophe.jaillet@wanadoo.fr> - 2016-08-12 12:10 +0200
  Re: [PATCH 2/2] be2iscsi: Fix some error messages Julia Lawall <julia.lawall@lip6.fr> - 2016-08-12 12:40 +0200
    Re: [PATCH 2/2] be2iscsi: Fix some error messages Christophe JAILLET <christophe.jaillet@wanadoo.fr> - 2016-08-12 22:40 +0200
      [PATCH 2/2 v2] be2iscsi: Fix some error messages Christophe JAILLET <christophe.jaillet@wanadoo.fr> - 2016-08-13 09:20 +0200
        Re: [PATCH 2/2 v2] be2iscsi: Fix some error messages Julia Lawall <julia.lawall@lip6.fr> - 2016-08-13 09:20 +0200
      [PATCH 2/2 v3] be2iscsi: Fix some error messages Christophe JAILLET <christophe.jaillet@wanadoo.fr> - 2016-08-13 09:30 +0200
        Re: [PATCH 2/2 v3] be2iscsi: Fix some error messages Joe Perches <joe@perches.com> - 2016-08-13 13:40 +0200
          Re: [PATCH 2/2 v3] be2iscsi: Fix some error messages Christophe JAILLET <christophe.jaillet@wanadoo.fr> - 2016-08-13 14:40 +0200
            Re: [PATCH 2/2 v3] be2iscsi: Fix some error messages Joe Perches <joe@perches.com> - 2016-08-13 18:50 +0200
              Re: [PATCH 2/2 v3] be2iscsi: Fix some error messages Joe Perches <joe@perches.com> - 2016-08-13 19:10 +0200
                [PATCH 1/2] be2iscsi: Coalesce split strings and formats Joe Perches <joe@perches.com> - 2016-08-14 10:40 +0200
                [PATCH 0/2] be2iscsi: Logging neatening Joe Perches <joe@perches.com> - 2016-08-14 10:40 +0200
                Re: [PATCH 0/2] be2iscsi: Logging neatening Bart Van Assche <Bart.VanAssche@sandisk.com> - 2016-08-14 16:40 +0200
                Re: [PATCH 0/2] be2iscsi: Logging neatening Joe Perches <joe@perches.com> - 2016-08-14 18:30 +0200
                Re: [PATCH 0/2] be2iscsi: Logging neatening Bart Van Assche <Bart.VanAssche@sandisk.com> - 2016-08-14 19:30 +0200
                Re: [PATCH 0/2] be2iscsi: Logging neatening Joe Perches <joe@perches.com> - 2016-08-14 19:40 +0200
                Re: [PATCH 0/2] be2iscsi: Logging neatening Bart Van Assche <Bart.VanAssche@sandisk.com> - 2016-08-17 04:00 +0200
                Re: [PATCH 0/2] be2iscsi: Logging neatening Joe Perches <joe@perches.com> - 2016-08-17 05:40 +0200
                Re: [PATCH] be2iscsi: Use a more current logging style Joe Perches <joe@perches.com> - 2016-08-16 12:30 +0200
                RE: [PATCH] be2iscsi: Use a more current logging style Jitendra Bhivare <jitendra.bhivare@broadcom.com> - 2016-08-17 06:00 +0200
                Re: [PATCH] be2iscsi: Use a more current logging style Joe Perches <joe@perches.com> - 2016-08-17 06:00 +0200

csiph-web