Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1461656

Re: [PATCH 2/2 v3] be2iscsi: Fix some error messages

Show all headers | View raw

On Sat, 2016-08-13 at 14:31 +0200, Christophe JAILLET wrote:
> Le 13/08/2016 à 13:35, Joe Perches a écrit :
> > > @@ -268,7 +268,7 @@ static int beiscsi_eh_abort(struct scsi_cmnd *sc)
> > >   				&nonemb_cmd.dma);
> > >   	if (nonemb_cmd.va == NULL) {
> > >   		beiscsi_log(phba, KERN_ERR, BEISCSI_LOG_EH,
> > > -			    "BM_%d : Failed to allocate memory for"
> > > +			    "BM_%d : Failed to allocate memory for "
> > >   			    "mgmt_invalidate_icds\n");
> > doesn't match commit log as no coalescing/concatenation
> > is done.
> > 
> > There are many of these.
> > 
> I have *only* fixed the one reported by checkpatch and left the others 
> unchanged.
> 
> My initial proposal was to fix incorrect strings, without modifying too 
> much the code. So I decided to do the minimum of changes.
> 
> Should I resubmitted with:
>     - all strings *in the patch* concatenated?
>     - all strings *in the file*" concatenated?

Hello Christophe

You don't _have_ to do anything.

I think the commit message is misleading.

You could submit another patch that does
the equivalent of:

$ ./scripts/checkpatch.pl --types=SPLIT_STRING --fix-inplace drivers/scsi/be2iscsi/be_main.c

with the appropriate commit message

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 2/2] be2iscsi: Fix some error messages Christophe JAILLET <christophe.jaillet@wanadoo.fr> - 2016-08-12 12:10 +0200
  Re: [PATCH 2/2] be2iscsi: Fix some error messages Julia Lawall <julia.lawall@lip6.fr> - 2016-08-12 12:40 +0200
    Re: [PATCH 2/2] be2iscsi: Fix some error messages Christophe JAILLET <christophe.jaillet@wanadoo.fr> - 2016-08-12 22:40 +0200
      [PATCH 2/2 v2] be2iscsi: Fix some error messages Christophe JAILLET <christophe.jaillet@wanadoo.fr> - 2016-08-13 09:20 +0200
        Re: [PATCH 2/2 v2] be2iscsi: Fix some error messages Julia Lawall <julia.lawall@lip6.fr> - 2016-08-13 09:20 +0200
      [PATCH 2/2 v3] be2iscsi: Fix some error messages Christophe JAILLET <christophe.jaillet@wanadoo.fr> - 2016-08-13 09:30 +0200
        Re: [PATCH 2/2 v3] be2iscsi: Fix some error messages Joe Perches <joe@perches.com> - 2016-08-13 13:40 +0200
          Re: [PATCH 2/2 v3] be2iscsi: Fix some error messages Christophe JAILLET <christophe.jaillet@wanadoo.fr> - 2016-08-13 14:40 +0200
            Re: [PATCH 2/2 v3] be2iscsi: Fix some error messages Joe Perches <joe@perches.com> - 2016-08-13 18:50 +0200
              Re: [PATCH 2/2 v3] be2iscsi: Fix some error messages Joe Perches <joe@perches.com> - 2016-08-13 19:10 +0200
                [PATCH 1/2] be2iscsi: Coalesce split strings and formats Joe Perches <joe@perches.com> - 2016-08-14 10:40 +0200
                [PATCH 0/2] be2iscsi: Logging neatening Joe Perches <joe@perches.com> - 2016-08-14 10:40 +0200
                Re: [PATCH 0/2] be2iscsi: Logging neatening Bart Van Assche <Bart.VanAssche@sandisk.com> - 2016-08-14 16:40 +0200
                Re: [PATCH 0/2] be2iscsi: Logging neatening Joe Perches <joe@perches.com> - 2016-08-14 18:30 +0200
                Re: [PATCH 0/2] be2iscsi: Logging neatening Bart Van Assche <Bart.VanAssche@sandisk.com> - 2016-08-14 19:30 +0200
                Re: [PATCH 0/2] be2iscsi: Logging neatening Joe Perches <joe@perches.com> - 2016-08-14 19:40 +0200
                Re: [PATCH 0/2] be2iscsi: Logging neatening Bart Van Assche <Bart.VanAssche@sandisk.com> - 2016-08-17 04:00 +0200
                Re: [PATCH 0/2] be2iscsi: Logging neatening Joe Perches <joe@perches.com> - 2016-08-17 05:40 +0200
                Re: [PATCH] be2iscsi: Use a more current logging style Joe Perches <joe@perches.com> - 2016-08-16 12:30 +0200
                RE: [PATCH] be2iscsi: Use a more current logging style Jitendra Bhivare <jitendra.bhivare@broadcom.com> - 2016-08-17 06:00 +0200
                Re: [PATCH] be2iscsi: Use a more current logging style Joe Perches <joe@perches.com> - 2016-08-17 06:00 +0200

csiph-web