Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1462255

Re: [PATCH 3.16 289/305] netfilter: x_tables: validate targets of jumps

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Sat, 2016-08-13 at 20:30 +0200, Florian Westphal wrote:
> > Ben Hutchings <ben@decadent.org.uk> wrote:
> > 
> > 3.16.37-rc1 review patch.  If anyone has any objections, please let me know.
> > 
> > ------------------
> > 
> > > > From: Florian Westphal <fw@strlen.de>
> > 
> > commit 36472341017529e2b12573093cc0f68719300997 upstream.
> 
> [..]
> 
> > 
> > The extra overhead is negible, even with absurd cases.
> 
> Not true, the overhead is huge and increases restore time for
> large rulesets from mere seconds to minutes, see
> 
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=f4dc77713f8016d2e8a3295e1c9c53a21f296def

So do you think I should add that to this update or defer the netfilter
changes to the next update?

Ben.

-- 
Ben Hutchings
Everything should be made as simple as possible, but not simpler.
                                                           - Albert
Einstein

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 3.16 289/305] netfilter: x_tables: validate targets of  jumps Florian Westphal <fw@strlen.de> - 2016-08-14 13:20 +0200
  Re: [PATCH 3.16 289/305] netfilter: x_tables: validate targets of  jumps Florian Westphal <fw@strlen.de> - 2016-08-14 15:20 +0200
    Re: [PATCH 3.16 289/305] netfilter: x_tables: validate targets of  jumps Ben Hutchings <ben@decadent.org.uk> - 2016-08-17 02:30 +0200
  Re: [PATCH 3.16 289/305] netfilter: x_tables: validate targets of  jumps Ben Hutchings <ben@decadent.org.uk> - 2016-08-14 20:10 +0200

csiph-web