Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1461889

Re: [PATCH 3.16 289/305] netfilter: x_tables: validate targets of jumps

From Florian Westphal <fw@strlen.de>
Newsgroups linux.kernel
Subject Re: [PATCH 3.16 289/305] netfilter: x_tables: validate targets of jumps
Date 2016-08-14 13:20 +0200
Message-ID <s61Cq-7hw-23@gated-at.bofh.it> (permalink)
References <s5LnX-4sk-3@gated-at.bofh.it> <s61Cq-7hw-25@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Ben Hutchings <ben@decadent.org.uk> wrote:
> 3.16.37-rc1 review patch.  If anyone has any objections, please let me know.
> 
> ------------------
> 
> From: Florian Westphal <fw@strlen.de>
> 
> commit 36472341017529e2b12573093cc0f68719300997 upstream.

[..]

> The extra overhead is negible, even with absurd cases.

Not true, the overhead is huge and increases restore time for
large rulesets from mere seconds to minutes, see

https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=f4dc77713f8016d2e8a3295e1c9c53a21f296def

Back to linux.kernel | Previous | NextNext in thread | Find similar | Unroll thread


Thread

Re: [PATCH 3.16 289/305] netfilter: x_tables: validate targets of  jumps Florian Westphal <fw@strlen.de> - 2016-08-14 13:20 +0200
  Re: [PATCH 3.16 289/305] netfilter: x_tables: validate targets of  jumps Florian Westphal <fw@strlen.de> - 2016-08-14 15:20 +0200
    Re: [PATCH 3.16 289/305] netfilter: x_tables: validate targets of  jumps Ben Hutchings <ben@decadent.org.uk> - 2016-08-17 02:30 +0200
  Re: [PATCH 3.16 289/305] netfilter: x_tables: validate targets of  jumps Ben Hutchings <ben@decadent.org.uk> - 2016-08-14 20:10 +0200

csiph-web