Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1461862

Re: staging: ks7010: Replace three printk() calls by pr_err()

Show all headers | View raw

> Really now, this is basic fixes and cleanups,

I agree to this view to some degree.


> you have been asked many times in the past to move on beyond these,

It is more useful when more severe bugs or bigger software improvements can be found.
Which source code clean-ups are picked better up by other contributors?


> as you often times seem to end up wasting lots of people's times
> as they attempt to help you.

It can take a bit more time occasionally to achieve the desired consensus.


> Personally, I'm long past wishing to help you out here, sorry.

Other contributors will eventually continue the clarification of remaining
open issues in the source file "ks7010_sdio.c".


> I'll take "correct" patches, but that's it.  No discussion of them, no
> arguing over theoreticals, and no telling you what I might, or might
> not, want to see done in the future, sorry.

I became aware about software development possibilities which can also
matter here.
Yesterday Julia Lawall informed me about a presentation on the topic
"Refactor strings – make everyone happy" by Wolfram Sang on 2016-07-14.

Is such a software evolution also interesting and acceptable for you?


> And really, your patch quality stinks, I strongly suggest getting a lot
> more experience with C first before doing more kernel work please.

Can you accept any specific update steps while other software changes
will evolve after a bit of discussion as usual?

Regards,
Markus

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 00/10] staging: ks7010: Fine-tuning for a SDIO card driver SF Markus Elfring <elfring@users.sourceforge.net> - 2016-08-11 07:20 +0200
  [PATCH v2 02/10] staging: ks7010: Delete unnecessary assignments for  buffer variables SF Markus Elfring <elfring@users.sourceforge.net> - 2016-08-11 07:30 +0200
  [PATCH v2 01/10] staging: ks7010: Delete unnecessary checks before  the function call "kfree" SF Markus Elfring <elfring@users.sourceforge.net> - 2016-08-11 07:30 +0200
  [PATCH v2 04/10] staging: ks7010: Rename jump labels SF Markus Elfring <elfring@users.sourceforge.net> - 2016-08-11 07:40 +0200
  [PATCH v2 03/10] staging: ks7010: Return directly after a failed  kmalloc() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-08-11 07:40 +0200
  [PATCH v2 05/10] staging: ks7010: Delete unnecessary uses of the  variable "retval" SF Markus Elfring <elfring@users.sourceforge.net> - 2016-08-11 07:40 +0200
  [PATCH v2 06/10] staging: ks7010: Delete unnecessary braces SF Markus Elfring <elfring@users.sourceforge.net> - 2016-08-11 07:50 +0200
  [PATCH v2 07/10] staging: ks7010: Add the macro "pr_fmt" SF Markus Elfring <elfring@users.sourceforge.net> - 2016-08-11 07:50 +0200
  [PATCH v2 08/10] staging: ks7010: Replace three printk() calls by  pr_err() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-08-11 07:50 +0200
    Re: [PATCH v2 08/10] staging: ks7010: Replace three printk() calls  by pr_err() Joe Perches <joe@perches.com> - 2016-08-12 21:50 +0200
      Re: staging: ks7010: Replace three printk() calls by pr_err() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-08-13 13:20 +0200
        Re: staging: ks7010: Replace three printk() calls by pr_err() Joe Perches <joe@perches.com> - 2016-08-13 19:40 +0200
          Re: staging: ks7010: Replace three printk() calls by pr_err() Joe Perches <joe@perches.com> - 2016-08-14 11:00 +0200
            Re: staging: ks7010: Replace three printk() calls by pr_err() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-08-14 12:10 +0200
              Re: staging: ks7010: Replace three printk() calls by pr_err() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-08-14 13:10 +0200
          Re: staging: ks7010: Replace three printk() calls by pr_err() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-08-14 11:30 +0200
  [PATCH v2 09/10] staging: ks7010: Delete a variable in  write_to_device() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-08-11 08:00 +0200
  [PATCH v2 10/10] staging: ks7010: Delete three unnecessary variable  initialisations SF Markus Elfring <elfring@users.sourceforge.net> - 2016-08-11 08:10 +0200
  Re: [PATCH v2 00/10] staging: ks7010: Fine-tuning for a SDIO card  driver SF Markus Elfring <elfring@users.sourceforge.net> - 2016-08-14 12:20 +0200
  Re: [PATCH v2 00/10] staging: ks7010: Fine-tuning for a SDIO card  driver Wolfram Sang <wsa@the-dreams.de> - 2016-08-14 14:10 +0200

csiph-web