Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1460918

[PATCH 16/18] autofs: Fix print format for ioctl warning message

Show all headers | View raw

From: Tomohiro Kusumi <kusumi.tomohiro@gmail.com>

All other warnings use "cmd(0x%08x)" and this is the only one with "cmd(%d)".
(below comes from my userspace debug program, but not automount daemon)

[ 1139.905676] autofs4:pid:1640:check_dev_ioctl_version: ioctl control interface version mismatch: kernel(1.0), user(0.0), cmd(-1072131215)

Signed-off-by: Tomohiro Kusumi <kusumi.tomohiro@gmail.com>
Signed-off-by: Ian Kent <ikent@redhat.com>
---
 fs/autofs4/dev-ioctl.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/autofs4/dev-ioctl.c b/fs/autofs4/dev-ioctl.c
index 7289216..e89d6bb 100644
--- a/fs/autofs4/dev-ioctl.c
+++ b/fs/autofs4/dev-ioctl.c
@@ -75,7 +75,7 @@ static int check_dev_ioctl_version(int cmd, struct autofs_dev_ioctl *param)
 	if ((param->ver_major != AUTOFS_DEV_IOCTL_VERSION_MAJOR) ||
 	    (param->ver_minor > AUTOFS_DEV_IOCTL_VERSION_MINOR)) {
 		pr_warn("ioctl control interface version mismatch: "
-			"kernel(%u.%u), user(%u.%u), cmd(%d)\n",
+			"kernel(%u.%u), user(%u.%u), cmd(0x%08x)\n",
 			AUTOFS_DEV_IOCTL_VERSION_MAJOR,
 			AUTOFS_DEV_IOCTL_VERSION_MINOR,
 			param->ver_major, param->ver_minor, cmd);

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 01/18] autofs: Fix typos in  Documentation/filesystems/autofs4.txt Ian Kent <raven@themaw.net> - 2016-08-12 04:50 +0200
  [PATCH 04/18] autofs - fix autofs4_fill_super() error exit handling Ian Kent <raven@themaw.net> - 2016-08-12 04:50 +0200
  [PATCH 15/18] autofs: Add autofs_dev_ioctl_version() for  AUTOFS_DEV_IOCTL_VERSION_CMD Ian Kent <raven@themaw.net> - 2016-08-12 04:50 +0200
  [PATCH 13/18] autofs: Fix pr_debug() message Ian Kent <raven@themaw.net> - 2016-08-12 04:50 +0200
  [PATCH 18/18] autofs4 - move linux/auto_dev-ioctl.h to uapi/linux Ian Kent <raven@themaw.net> - 2016-08-12 04:50 +0200
  [PATCH 05/18] autofs: Add WARN_ON(1) for non dir/link inode case Ian Kent <raven@themaw.net> - 2016-08-12 04:50 +0200
  [PATCH 06/18] autofs - remove ino free in autofs4_dir_symlink() Ian Kent <raven@themaw.net> - 2016-08-12 04:50 +0200
  [PATCH 11/18] autofs: Fix Documentation regarding devid on ioctl Ian Kent <raven@themaw.net> - 2016-08-12 04:50 +0200
  [PATCH 16/18] autofs: Fix print format for ioctl warning message Ian Kent <raven@themaw.net> - 2016-08-12 04:50 +0200
  [PATCH 09/18] autofs: Don't fail to free_dev_ioctl(param) Ian Kent <raven@themaw.net> - 2016-08-12 05:00 +0200
  [PATCH 14/18] autofs - fix dev ioctl number range check Ian Kent <raven@themaw.net> - 2016-08-12 05:00 +0200
  [PATCH 12/18] autofs: Update struct autofs_dev_ioctl in  Documentation Ian Kent <raven@themaw.net> - 2016-08-12 05:00 +0200
  [PATCH 02/18] autofs: Drop unnecessary extern in autofs_i.h Ian Kent <raven@themaw.net> - 2016-08-12 05:00 +0200

csiph-web